From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cifDM-0001Hy-4z for qemu-devel@nongnu.org; Tue, 28 Feb 2017 05:41:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cifDL-0002d2-1v for qemu-devel@nongnu.org; Tue, 28 Feb 2017 05:41:04 -0500 References: <1487623279-29930-1-git-send-email-hpoussin@reactos.org> <06b73003-0e57-4ba0-d54c-d93604397770@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 28 Feb 2017 11:40:49 +0100 MIME-Version: 1.0 In-Reply-To: <06b73003-0e57-4ba0-d54c-d93604397770@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-devel@nongnu.org Cc: Michael Tokarev , Markus Armbruster , qemu-block@nongnu.org On 27/02/2017 20:25, John Snow wrote: >=20 >=20 > On 02/27/2017 01:45 PM, Herv=C3=A9 Poussineau wrote: >> Ping? >> >> Le 20/02/2017 =C3=A0 21:41, Herv=C3=A9 Poussineau a =C3=A9crit : >>> In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011), >>> ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, >>> "or else you can't put one on secondary master without -nodefaults". >>> >>> Make it the same for scsi-hd, so you can put one on scsi-id 2 without >>> using -nodefaults. >>> scsi-hd has probably been forgotten, as it has been added in the >>> preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce). >>> >>> Affected users are the ones using a machine with SCSI devices and >>> start QEMU >>> with -device scsi-hd but without -device scsi-cd or -cdrom >>> In that case, the default cdrom device will disappear instead of bein= g >>> empty. >>> >>> Signed-off-by: Herv=C3=A9 Poussineau >>> --- >>> vl.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/vl.c b/vl.c >>> index 27d9829..4af95b3 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -226,6 +226,7 @@ static struct { >>> { .driver =3D "ide-hd", .flag =3D &default_cdrom = }, >>> { .driver =3D "ide-drive", .flag =3D &default_cdrom = }, >>> { .driver =3D "scsi-cd", .flag =3D &default_cdrom = }, >>> + { .driver =3D "scsi-hd", .flag =3D &default_cdrom = }, >>> { .driver =3D "virtio-serial-pci", .flag =3D &default_virtcon= }, >>> { .driver =3D "virtio-serial", .flag =3D &default_virtcon= }, >>> { .driver =3D "VGA", .flag =3D &default_vga = }, >>> >> >> >=20 > ACK >=20 > Paolo, for you? Or for Eduardo or Markus... I'll pick it. Paolo