* [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd
@ 2017-02-20 20:41 Hervé Poussineau
2017-02-27 18:45 ` Hervé Poussineau
0 siblings, 1 reply; 4+ messages in thread
From: Hervé Poussineau @ 2017-02-20 20:41 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Michael Tokarev, Markus Armbruster, John Snow,
qemu-block, Hervé Poussineau
In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
"or else you can't put one on secondary master without -nodefaults".
Make it the same for scsi-hd, so you can put one on scsi-id 2 without
using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the
preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
Affected users are the ones using a machine with SCSI devices and start QEMU
with -device scsi-hd but without -device scsi-cd or -cdrom
In that case, the default cdrom device will disappear instead of being empty.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 27d9829..4af95b3 100644
--- a/vl.c
+++ b/vl.c
@@ -226,6 +226,7 @@ static struct {
{ .driver = "ide-hd", .flag = &default_cdrom },
{ .driver = "ide-drive", .flag = &default_cdrom },
{ .driver = "scsi-cd", .flag = &default_cdrom },
+ { .driver = "scsi-hd", .flag = &default_cdrom },
{ .driver = "virtio-serial-pci", .flag = &default_virtcon },
{ .driver = "virtio-serial", .flag = &default_virtcon },
{ .driver = "VGA", .flag = &default_vga },
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd
2017-02-20 20:41 [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd Hervé Poussineau
@ 2017-02-27 18:45 ` Hervé Poussineau
2017-02-27 19:25 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Hervé Poussineau @ 2017-02-27 18:45 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Michael Tokarev, Markus Armbruster, John Snow,
qemu-block
Ping?
Le 20/02/2017 à 21:41, Hervé Poussineau a écrit :
> In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
> ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
> "or else you can't put one on secondary master without -nodefaults".
>
> Make it the same for scsi-hd, so you can put one on scsi-id 2 without
> using -nodefaults.
> scsi-hd has probably been forgotten, as it has been added in the
> preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
>
> Affected users are the ones using a machine with SCSI devices and start QEMU
> with -device scsi-hd but without -device scsi-cd or -cdrom
> In that case, the default cdrom device will disappear instead of being empty.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 27d9829..4af95b3 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -226,6 +226,7 @@ static struct {
> { .driver = "ide-hd", .flag = &default_cdrom },
> { .driver = "ide-drive", .flag = &default_cdrom },
> { .driver = "scsi-cd", .flag = &default_cdrom },
> + { .driver = "scsi-hd", .flag = &default_cdrom },
> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
> { .driver = "virtio-serial", .flag = &default_virtcon },
> { .driver = "VGA", .flag = &default_vga },
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd
2017-02-27 18:45 ` Hervé Poussineau
@ 2017-02-27 19:25 ` John Snow
2017-02-28 10:40 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: John Snow @ 2017-02-27 19:25 UTC (permalink / raw)
To: Hervé Poussineau, qemu-devel
Cc: Paolo Bonzini, Michael Tokarev, Markus Armbruster, qemu-block
On 02/27/2017 01:45 PM, Hervé Poussineau wrote:
> Ping?
>
> Le 20/02/2017 à 21:41, Hervé Poussineau a écrit :
>> In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
>> ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
>> "or else you can't put one on secondary master without -nodefaults".
>>
>> Make it the same for scsi-hd, so you can put one on scsi-id 2 without
>> using -nodefaults.
>> scsi-hd has probably been forgotten, as it has been added in the
>> preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
>>
>> Affected users are the ones using a machine with SCSI devices and
>> start QEMU
>> with -device scsi-hd but without -device scsi-cd or -cdrom
>> In that case, the default cdrom device will disappear instead of being
>> empty.
>>
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>> ---
>> vl.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 27d9829..4af95b3 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -226,6 +226,7 @@ static struct {
>> { .driver = "ide-hd", .flag = &default_cdrom },
>> { .driver = "ide-drive", .flag = &default_cdrom },
>> { .driver = "scsi-cd", .flag = &default_cdrom },
>> + { .driver = "scsi-hd", .flag = &default_cdrom },
>> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
>> { .driver = "virtio-serial", .flag = &default_virtcon },
>> { .driver = "VGA", .flag = &default_vga },
>>
>
>
ACK
Paolo, for you?
--js
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd
2017-02-27 19:25 ` John Snow
@ 2017-02-28 10:40 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-02-28 10:40 UTC (permalink / raw)
To: John Snow, Hervé Poussineau, qemu-devel
Cc: Michael Tokarev, Markus Armbruster, qemu-block
On 27/02/2017 20:25, John Snow wrote:
>
>
> On 02/27/2017 01:45 PM, Hervé Poussineau wrote:
>> Ping?
>>
>> Le 20/02/2017 à 21:41, Hervé Poussineau a écrit :
>>> In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
>>> ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
>>> "or else you can't put one on secondary master without -nodefaults".
>>>
>>> Make it the same for scsi-hd, so you can put one on scsi-id 2 without
>>> using -nodefaults.
>>> scsi-hd has probably been forgotten, as it has been added in the
>>> preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
>>>
>>> Affected users are the ones using a machine with SCSI devices and
>>> start QEMU
>>> with -device scsi-hd but without -device scsi-cd or -cdrom
>>> In that case, the default cdrom device will disappear instead of being
>>> empty.
>>>
>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>> ---
>>> vl.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 27d9829..4af95b3 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -226,6 +226,7 @@ static struct {
>>> { .driver = "ide-hd", .flag = &default_cdrom },
>>> { .driver = "ide-drive", .flag = &default_cdrom },
>>> { .driver = "scsi-cd", .flag = &default_cdrom },
>>> + { .driver = "scsi-hd", .flag = &default_cdrom },
>>> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
>>> { .driver = "virtio-serial", .flag = &default_virtcon },
>>> { .driver = "VGA", .flag = &default_vga },
>>>
>>
>>
>
> ACK
>
> Paolo, for you?
Or for Eduardo or Markus... I'll pick it.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-28 10:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 20:41 [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd Hervé Poussineau
2017-02-27 18:45 ` Hervé Poussineau
2017-02-27 19:25 ` John Snow
2017-02-28 10:40 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).