From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0B70EB64D7 for ; Fri, 16 Jun 2023 14:01:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAA0k-0006Qg-1v; Fri, 16 Jun 2023 10:01:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAA0g-0006P1-VX for qemu-devel@nongnu.org; Fri, 16 Jun 2023 10:01:07 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAA0e-0004wi-FH for qemu-devel@nongnu.org; Fri, 16 Jun 2023 10:01:06 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-30c4c1fd511so560850f8f.1 for ; Fri, 16 Jun 2023 07:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686924063; x=1689516063; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n8AuekZeNcC6N2BLHlhkki18GOpXN0XdSt2mq7QEgMg=; b=hi1Fthb4Y841gHS9od+cFebkadJlLHSBzr5zBiO3bAvXXOLIgzCVNYLQULW2RGajc0 2unBkPpJRRx4uNWzT9BTxSuJJuclycB2AsErz3gQfzlcZ+UdqyCKec7zbdbv/Cvpkxxk mbiPVfIL8LsZeioe2GN/g1vSdUq08AcGk4y9vexeZ2TlQQp+Fn6a8C6bLDEl5WHuaCii O64VhA1tfBXzNWQiRGe0HVQmkXgoJrwY75tGbv0KUd2am23DaK7TmxezoljV3lqfzYVK NOF1CL3YM5l1FPjmnfR4vnKogcUrkFCDfWq88yDfWdgaCSazENRKFB2R4A8PvU5gdgxi SW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686924063; x=1689516063; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8AuekZeNcC6N2BLHlhkki18GOpXN0XdSt2mq7QEgMg=; b=GGJUncbRGnkziBIbzwyDonOpq7FIvbRZ0A4jGr3MDVigJ1pPS7h5Odve4N0eBwX5YP +jeoHCS2WgTGj6VSBi0Cm0cNZ6NUID8TB2odleeS56zNYR8C85iG2IRzlyVjZqvZDvCZ TURL0C02VNIZCCJMRcG/V1tptVJ8j5DNlRia33dNxAJICQGdhCDT3KWVeL0RlttIACXk hm1F96EK9czj3Omp3Rmz8VhVDqiUDJ6sv3gdfnm7dpEKNM7jdmIdSxDEgUNbJzjkXTmS 2pQn/MVCcbKCX8NP3uJ+IJUGUOhZ8P1fjYkivk2erDElXKFRr8USwTyRyLS6mhht2PHk RFaA== X-Gm-Message-State: AC+VfDzavodXRV2J2em1sqpkUH/WRViEx+fg4X2aShUCDu8HzJXI6VbN bPlS8bS3dfxHVF6Am7eXXVJ6Wg== X-Google-Smtp-Source: ACHHUZ43yK27ICOKaUL4FPOw2eUuCEZrCS+nHPjcL+0b9nSrK78vkggMEx4h1YgZbH9E4JHGqmn0PQ== X-Received: by 2002:adf:f046:0:b0:30f:c3e4:506b with SMTP id t6-20020adff046000000b0030fc3e4506bmr1528003wro.44.1686924062166; Fri, 16 Jun 2023 07:01:02 -0700 (PDT) Received: from [192.168.164.175] (146.red-88-29-160.dynamicip.rima-tde.net. [88.29.160.146]) by smtp.gmail.com with ESMTPSA id t11-20020adfdc0b000000b0030ae3a6be5bsm23837728wri.78.2023.06.16.07.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 07:01:01 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 12:31:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 04/12] hvf: arm: Ignore writes to CNTP_CTL_EL0 Content-Language: en-US To: Alexander Graf , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, qemu-arm@nongnu.org, Cameron Esfahani , Roman Bolshakov , Stefan Hajnoczi , "Michael S. Tsirkin" , Kevin Wolf , Hanna Reitz , Marcel Apfelbaum , Paolo Bonzini , Peter Maydell References: <20230614224038.86148-1-graf> <20230614225407.96216-1-graf@amazon.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230614225407.96216-1-graf@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.093, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 15/6/23 00:54, Alexander Graf wrote: > MacOS unconditionally disables interrupts of the physical timer on boot > and then continues to use the virtual one. We don't really want to support > a full physical timer emulation, so let's just ignore those writes. > > Signed-off-by: Alexander Graf > --- > target/arm/hvf/hvf.c | 7 +++++++ > 1 file changed, 7 insertions(+) > @@ -1551,6 +1552,12 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t reg, uint64_t val) > case SYSREG_OSLAR_EL1: > env->cp15.oslsr_el1 = val & 1; > break; > + case SYSREG_CNTP_CTL_EL0: > + /* > + * Guests should not rely on the physical counter, but macOS emits > + * disable writes to it. Let it do so, but ignore the requests. > + */ Still it could be useful to report that calling qemu_log_mask(LOG_UNIMP,...) here. > + break;