From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 028A7EEB59E for ; Thu, 12 Sep 2024 12:01:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soiUK-0001ti-RY; Thu, 12 Sep 2024 07:59:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soiTv-0001lX-J2 for qemu-devel@nongnu.org; Thu, 12 Sep 2024 07:59:28 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soiTp-00044n-1l for qemu-devel@nongnu.org; Thu, 12 Sep 2024 07:59:27 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-42cbbb1727eso7148515e9.2 for ; Thu, 12 Sep 2024 04:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726142359; x=1726747159; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S9hH4zorKUC2orkfwALmr2q6s1FZ/UxiA+b+T0QKDfM=; b=haFrBfSftilxfimz3bMpDd/dPSBYazDqKxtZH2iK6pynOZk+SKyyJ5xGlT/VtD/B4v 0RyaZgEAjM/V5kL6qrfwhGk4YsdJMJ/jAE87RsJjV4idMuFutbEK3c8fS9c4/GW6N4FI LzHMAV+GSAz8z0y9IwK2TNkHLRdZmdgQIkY5Rk/ZzYZaXruMcoB8iubYilLEhiJ1VoMA QWKuOeWia95azOA9GLNZT6Fi4yW52H+CqCdBopoNwZLe6SlGnM0ZvJTvwnzfel/PoTbc atGwJJMIG5wkyUjZbblASHHIETFeo90/qDv19rsYFmhTjq+NjNAOi6Z54chRh7hO4ok9 DGlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726142359; x=1726747159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9hH4zorKUC2orkfwALmr2q6s1FZ/UxiA+b+T0QKDfM=; b=nq/C2N7WbkIx1FgGoMK86zUMnfQJdr15Lq6aY10GeD1n0DYqmVr2/3VR0SmIUYX9A8 Vr8xEyE9ZOzqoSHIoNCFoHig3jIsEFHwZrn/KIcxUgcJwJ+qeAqfKINQJHdH8nvUsOyr fqTR0bu3lF1kdVMKPZfp1+YXgHBLwph5kVZNFdAjp0fl8sff71FARrhrYiKLSoBLbWdn mjWoTnJky3SzvZ874Ns1JbxFL8ke+kWOSZ60Lpj0mClJEkND7Ax/VNOmZAf24sPIQdez 6+ZcpxfpIdYKW02r34iduruKyDBVEfmukFH5JQm+BDJ6IheL6dSVsvVDHFHFxX/qXHC2 cydg== X-Forwarded-Encrypted: i=1; AJvYcCU+63dVlsHp8YtSQgpHNe9wB/YM6zEkWAWogg+AHAX8tpm3f6NWQ6870eVTBoSnYuqa5WBHlXCr7mkk@nongnu.org X-Gm-Message-State: AOJu0YzRrGz9J9n6vDE50WZtev1HqIuqFswYxgiePQ30amEHuYGb7Dx6 9kB7qN5h8F9aqRwWO/4BUDD3xMkQKwHwOwy6f7mB6xXgcBaejQWCb+Tn9QpR968= X-Google-Smtp-Source: AGHT+IHdMYpvkErKC3W9i3z+Ft8XhpOoUilHTYrpJoqTJq/qhlwtnn61XatlsIjXjk2IjSojx5FOxQ== X-Received: by 2002:a05:600c:1c28:b0:42c:ba1f:5452 with SMTP id 5b1f17b1804b1-42cdb57c022mr22778035e9.25.1726142358622; Thu, 12 Sep 2024 04:59:18 -0700 (PDT) Received: from [192.168.1.102] ([176.176.161.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb44887sm171920365e9.23.2024.09.12.04.59.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 04:59:18 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 13:59:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached() To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Jason Wang , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> <20240912073921.453203-15-pierrick.bouvier@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240912073921.453203-15-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/9/24 09:38, Pierrick Bouvier wrote: > This patch is part of a series that moves towards a consistent use of > g_assert_not_reached() rather than an ad hoc mix of different > assertion mechanisms. > > Reviewed-by: Richard Henderson > Reviewed-by: Thomas Huth > Signed-off-by: Pierrick Bouvier > --- > include/hw/s390x/cpu-topology.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) We usually don't precise "include/" in patch subject: we treat include/FOO as part of FOO area.