Re: [PATCH V3 0/4] Introduce Advanced Watch Dog module

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/12/19 18:52, Zhang, Chen wrote:
> Hi All~
> 
> No news for a long time.
> 
> Please give me more comments about this series.

Sorry, people were probably busy with the QEMU release candidates.

Even before looking at the code, the series is completely missing
documentation on how to use it and on the chardev protocol.  The
documentation should go in docs/ and should be written as restructuredText.

The qemu-options.hx patches also lack documentation about the properties
accepted by the new object.

In particular:

>> -chardev socket,id=h1,host=3.3.3.3,port=9009,server,nowait
>> -chardev socket,id=heartbeat0,host=3.3.3.3,port=4445
>> -object iothread,id=iothread2
>> -object
>> advanced-watchdog,id=heart1,server=on,awd_node=h1,notification_node=heartbeat0,opt_script=colo_opt_script_path,iothread=iothread1,pulse_interval=1000,timeout=5000

What are the two sockets for, and what should be in colo_opt_script_path?

>>
>> In secondary node:
>>
>> -monitor tcp::4445,server,nowait
>> -chardev socket,id=h1,host=3.3.3.3,port=9009,reconnect=1
>> -chardev socket,id=heart1,host=3.3.3.8,port=4445
>> -object iothread,id=iothread1
>> -object
>> advanced-watchdog,id=heart1,server=off,awd_node=h1,notification_node=heart1,opt_script=colo_secondary_opt_script,iothread=iothread1,timeout=10000

Same here.

Paolo