From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bilal Elmoussaoui <belmouss@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2] dbus: Properly dispose touch/mouse dbus objects
Date: Fri, 1 Sep 2023 16:28:13 +0200 [thread overview]
Message-ID: <a0683cdc-9e90-f115-d477-8adf4682d4ee@linaro.org> (raw)
In-Reply-To: <20230901124507.94087-1-belmouss@redhat.com>
On 1/9/23 14:45, Bilal Elmoussaoui wrote:
Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")
> Signed-off-by: Bilal Elmoussaoui <belmouss@redhat.com>
> ---
> ui/dbus-console.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ui/dbus-console.c b/ui/dbus-console.c
> index e19774f985..36f7349585 100644
> --- a/ui/dbus-console.c
> +++ b/ui/dbus-console.c
> @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
> DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
>
> unregister_displaychangelistener(&ddc->dcl);
> + g_clear_object(&ddc->iface_touch);
> + g_clear_object(&ddc->iface_mouse);
> g_clear_object(&ddc->iface_kbd);
> g_clear_object(&ddc->iface);
> g_clear_pointer(&ddc->listeners, g_hash_table_unref);
prev parent reply other threads:[~2023-09-01 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 12:45 [PATCH v2] dbus: Properly dispose touch/mouse dbus objects Bilal Elmoussaoui
2023-09-01 14:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0683cdc-9e90-f115-d477-8adf4682d4ee@linaro.org \
--to=philmd@linaro.org \
--cc=belmouss@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).