From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf'
Date: Mon, 28 Sep 2020 18:49:52 +0200 [thread overview]
Message-ID: <a08d86e3-25ef-1f0f-ee91-651628fbb20b@redhat.com> (raw)
In-Reply-To: <20200928143914.GK2230076@redhat.com>
On 28/09/20 16:39, Daniel P. Berrangé wrote:
> Looks like 2.58.0, which is still a fair bit newer than our 2.48 min.
>
> NB, only the macro changed - they were using GNU printf impl for many
> many years before that but simply had the wrong macro definition
>
> We can just sacrifice -Wformat checking for Windows builds when using
> old GLib. People building natively on Windows with MSys probably have
> brand new GLib, and those using Fedora mingw / Debian MXE also have
> pretty new GLib.
In the past we also had different minimal GLib versions for Windows and
POSIX systems.
Paolo
next prev parent reply other threads:[~2020-09-28 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 12:58 [PATCH 0/3] qemu/compiler: Remove unused special case code for GCC < 4.8 Philippe Mathieu-Daudé
2020-09-28 12:58 ` [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' Philippe Mathieu-Daudé
2020-09-28 13:43 ` Peter Maydell
2020-09-28 14:04 ` Daniel P. Berrangé
2020-09-28 14:14 ` Peter Maydell
2020-09-28 14:23 ` Daniel P. Berrangé
2020-09-28 14:32 ` Peter Maydell
2020-09-28 14:39 ` Daniel P. Berrangé
2020-09-28 16:49 ` Paolo Bonzini [this message]
2020-09-28 12:58 ` [PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler Philippe Mathieu-Daudé
2020-09-28 13:36 ` Peter Maydell
2020-11-25 15:07 ` Marc-André Lureau
2020-09-28 12:58 ` [PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6 Philippe Mathieu-Daudé
2020-09-28 13:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a08d86e3-25ef-1f0f-ee91-651628fbb20b@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).