From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] migration: Remove spurious files
Date: Thu, 9 Feb 2023 14:40:52 +0100 [thread overview]
Message-ID: <a09080c1-c033-4442-fd17-d88ae9b7aff3@linaro.org> (raw)
In-Reply-To: <20230209121449.30232-1-quintela@redhat.com>
On 9/2/23 13:14, Juan Quintela wrote:
> I introduced spurious files on my tree during a rebase:
>
> commit ebfc57871506b3fe36cc41f69ee3ad31a34afd63
> Author: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Date: Mon Oct 17 15:53:51 2022 +0800
>
> multifd: Fix flush of zero copy page send request
>
> Make IO channel flush call after the inflight request has been drained
> in multifd thread, or else we may missed to flush the inflight request.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> To make things worse, it appears like Zhenzhong is the one to blame.
>
> for(int i=0; i < 1000000; i++) {
> printf("I will not do rebases when I am tired\n");
> }
>
> Sorry, Juan.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> .../x86_64-quintela-devices.mak | 7 -
> .../x86_64-quintela2-devices.mak | 6 -
> migration/multifd.c.orig | 1274 -----------------
> 3 files changed, 1287 deletions(-)
Nice diff-stat! ;P
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-02-09 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 12:14 [PATCH] migration: Remove spurious files Juan Quintela
2023-02-09 12:17 ` Cédric Le Goater
2023-02-09 12:17 ` Daniel P. Berrangé
2023-02-09 13:40 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09080c1-c033-4442-fd17-d88ae9b7aff3@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).