From: Thomas Huth <thuth@redhat.com>
To: "Felix Queißner" <qemu-devel@mq32.de>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option.
Date: Thu, 23 Jun 2022 17:18:25 +0200 [thread overview]
Message-ID: <a0a7c39d-a60a-cfe0-c297-f08aba63cca6@redhat.com> (raw)
In-Reply-To: <020edc4f-32b2-fa76-12b8-cc0a455a8233@mailbox.org>
On 23/06/2022 17.05, Felix Queißner wrote:
>
>> Not sure why it was never picked up
>>
>> That patch certainly needs a re-spin since it won't apply as-is anymore.
>> Want to have a try?
>
> I guess the semantics of the code stay the same, but the boilerplate might
> change a bit?
>
> If so, i guess i can give it a try tomorrow and see if i can make it work.
The part that affects vl.c has changed completely - you now have to declare
it in the "QAPI schema" in the file qapi/ui.json instead (and it has to use
"-" instead of "_" now).
Just have a look how grab_on_hover is handled nowadays, then you'll should
be able to figure it out, I think.
HTH,
Thomas
prev parent reply other threads:[~2022-06-23 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 9:51 [Qemu-devel] [PATCH] gtk: Add show_tabs=on|off command line option Igor S
2022-06-23 14:36 ` Felix Queißner
2022-06-23 14:59 ` Thomas Huth
2022-06-23 15:00 ` Thomas Huth
2022-06-23 15:05 ` Felix Queißner
2022-06-23 15:18 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a7c39d-a60a-cfe0-c297-f08aba63cca6@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@mq32.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).