From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Gavin Shan <gshan@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v2 0/3] exec: Build page-vary-common.c with -fno-lto
Date: Mon, 22 Mar 2021 14:00:21 +0100 [thread overview]
Message-ID: <a0a7f1e2-2266-79e3-11f0-8fb6ef6ddc32@redhat.com> (raw)
In-Reply-To: <20210322112427.4045204-1-f4bug@amsat.org>
On 22/03/21 12:24, Philippe Mathieu-Daudé wrote:
> Hi,
>
> While reviewing Richard's original patch, I split it in 3
> to make it more digestible to my review taste. I then simply
> filled the patch descriptions. Feel free to keep Richard's v1
> if this isn't worth it.
>
> What is still missing is adding the new files to a MAINTAINERS
> section.
Both versions look good, thanks (the split is indeed more digestible)!
Richard, are you going to queue one of them?
Paolo
> Regards,
>
> Phil.
>
> Supersedes: <20210321211534.2101231-1-richard.henderson@linaro.org>
>
> Richard Henderson (3):
> exec: Rename exec-vary.c as page-vary.c
> exec: Extract 'page-vary.h' header
> exec: Build page-vary-common.c with -fno-lto
>
> configure | 19 -------
> meson.build | 18 ++++++-
> include/exec/cpu-all.h | 15 ++----
> include/exec/page-vary.h | 34 ++++++++++++
> exec-vary.c | 108 ---------------------------------------
> page-vary-common.c | 54 ++++++++++++++++++++
> page-vary.c | 41 +++++++++++++++
> 7 files changed, 150 insertions(+), 139 deletions(-)
> create mode 100644 include/exec/page-vary.h
> delete mode 100644 exec-vary.c
> create mode 100644 page-vary-common.c
> create mode 100644 page-vary.c
>
next prev parent reply other threads:[~2021-03-22 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 11:24 [PATCH v2 0/3] exec: Build page-vary-common.c with -fno-lto Philippe Mathieu-Daudé
2021-03-22 11:24 ` [PATCH v2 1/3] exec: Rename exec-vary.c as page-vary.c Philippe Mathieu-Daudé
2021-03-22 11:24 ` [PATCH v2 2/3] exec: Extract 'page-vary.h' header Philippe Mathieu-Daudé
2021-03-22 11:24 ` [PATCH v2 3/3] exec: Build page-vary-common.c with -fno-lto Philippe Mathieu-Daudé
2021-03-22 13:00 ` Paolo Bonzini [this message]
2021-03-22 21:49 ` [PATCH v2 0/3] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a7f1e2-2266-79e3-11f0-8fb6ef6ddc32@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=gshan@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).