From: Richard Henderson <richard.henderson@linaro.org>
To: Jan Bobek <jan.bobek@gmail.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [RISU v2 01/11] Makefile: undefine the arch name symbol
Date: Sat, 18 May 2019 08:26:25 -0700 [thread overview]
Message-ID: <a0a9d816-c16a-4071-50e6-aa29a817df53@linaro.org> (raw)
In-Reply-To: <20190517224450.15566-2-jan.bobek@gmail.com>
On 5/17/19 3:44 PM, Jan Bobek wrote:
> At least GCC defines the symbol "i386" to 1 to signal the target
> platform. We need to use "i386" as an undefined symbol in order to
> correctly include risu_reginfo_i386.h from risu.h. Add an -U option to
> the build command to make sure the symbol remains undefined.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Jan Bobek <jan.bobek@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-05-18 15:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 22:44 [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 01/11] Makefile: undefine the arch name symbol Jan Bobek
2019-05-18 15:26 ` Richard Henderson [this message]
2019-05-20 11:47 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 02/11] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h Jan Bobek
2019-05-18 15:27 ` Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 03/11] risu_i386: move reginfo-related code to risu_reginfo_i386.c Jan Bobek
2019-05-18 15:27 ` Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 04/11] risu_reginfo_i386: implement arch-specific reginfo interface Jan Bobek
2019-05-18 15:31 ` Richard Henderson
2019-05-20 12:11 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 05/11] risu_i386: implement missing CPU-specific functions Jan Bobek
2019-05-18 15:34 ` Richard Henderson
2019-05-20 12:12 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 06/11] risu_i386: remove old unused code Jan Bobek
2019-05-18 15:35 ` Richard Henderson
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 07/11] test_i386: change syntax from nasm to gas Jan Bobek
2019-05-18 15:37 ` Richard Henderson
2019-05-20 12:17 ` Alex Bennée
2019-05-20 22:43 ` Richard Henderson
2019-05-21 9:08 ` Alex Bennée
2019-05-21 13:32 ` Richard Henderson
2019-05-21 15:30 ` Alex Bennée
2019-05-21 16:48 ` Jan Bobek
2019-05-21 16:56 ` Richard Henderson
2019-05-21 17:07 ` Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 08/11] configure: add i386/x86_64 architectures Jan Bobek
2019-05-18 15:37 ` Richard Henderson
2019-05-20 12:17 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 09/11] i386: Add avx512 state to reginfo_t Jan Bobek
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names Jan Bobek
2019-05-18 15:59 ` Richard Henderson
2019-05-20 12:18 ` Alex Bennée
2019-05-17 22:44 ` [Qemu-devel] [RISU v2 11/11] risu_reginfo_i386: accept named feature sets for --xfeature Jan Bobek
2019-05-18 16:00 ` Richard Henderson
2019-05-18 12:23 ` [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions Alex Bennée
2019-05-20 12:30 ` Alex Bennée
2019-05-21 15:28 ` Jan Bobek
2019-05-21 16:49 ` Richard Henderson
2019-05-23 18:03 ` Jan Bobek
2019-05-23 18:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a9d816-c16a-4071-50e6-aa29a817df53@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=jan.bobek@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).