From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX9qa-0000r0-46 for qemu-devel@nongnu.org; Mon, 17 Jul 2017 13:30:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX9qZ-0007G5-BE for qemu-devel@nongnu.org; Mon, 17 Jul 2017 13:30:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37068) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX9qZ-0007Er-4s for qemu-devel@nongnu.org; Mon, 17 Jul 2017 13:30:15 -0400 References: <1500028867-134709-1-git-send-email-borntraeger@de.ibm.com> <1500028867-134709-35-git-send-email-borntraeger@de.ibm.com> From: David Hildenbrand Message-ID: Date: Mon, 17 Jul 2017 19:30:11 +0200 MIME-Version: 1.0 In-Reply-To: <1500028867-134709-35-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 34/40] s390x/cpumodel: wire up new hardware features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Peter Maydell Cc: Thomas Huth , Cornelia Huck , qemu-devel , Alexander Graf , "Jason J. Herne" , Richard Henderson On 14.07.2017 12:41, Christian Borntraeger wrote: > From: "Jason J. Herne" > > Some new guest features have been introduced recently. Let's wire > them up in the CPU model. > > Signed-off-by: Jason J. Herne > Acked-by: Christian Borntraeger > Acked-by: Cornelia Huck > Signed-off-by: Christian Borntraeger > [split patch] > --- Would it make sense to add further checks to check_consistency? I think e.g. vx extensions should rely on vx. I can't see a new PoP out there, so I can't check. -- Thanks, David