* [PATCH v2] ppc/xive: Fix uint32_t overflow
@ 2023-09-14 15:46 Cédric Le Goater
2023-09-18 10:32 ` Daniel Henrique Barboza
0 siblings, 1 reply; 2+ messages in thread
From: Cédric Le Goater @ 2023-09-14 15:46 UTC (permalink / raw)
To: qemu-ppc, qemu-devel
Cc: Frédéric Barrat, Nicholas Piggin, Peter Maydell,
Cédric Le Goater, Philippe Mathieu-Daudé
As reported by Coverity, "idx << xive->pc_shift" is evaluated using
32-bit arithmetic, and then used in a context expecting a "uint64_t".
Add a uint64_t cast.
Fixes: Coverity CID 1519049
Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>
---
v2: removed extra space after cast
hw/intc/pnv_xive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c
index 9b10e905195a..bda3478b1f84 100644
--- a/hw/intc/pnv_xive.c
+++ b/hw/intc/pnv_xive.c
@@ -210,7 +210,7 @@ static uint64_t pnv_xive_vst_addr_remote(PnvXive *xive, uint32_t type,
return 0;
}
- remote_addr |= idx << xive->pc_shift;
+ remote_addr |= ((uint64_t)idx) << xive->pc_shift;
vst_addr = address_space_ldq_be(&address_space_memory, remote_addr,
MEMTXATTRS_UNSPECIFIED, &result);
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] ppc/xive: Fix uint32_t overflow
2023-09-14 15:46 [PATCH v2] ppc/xive: Fix uint32_t overflow Cédric Le Goater
@ 2023-09-18 10:32 ` Daniel Henrique Barboza
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Henrique Barboza @ 2023-09-18 10:32 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc, qemu-devel
Cc: Frédéric Barrat, Nicholas Piggin, Peter Maydell,
Philippe Mathieu-Daudé
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
On 9/14/23 12:46, Cédric Le Goater wrote:
> As reported by Coverity, "idx << xive->pc_shift" is evaluated using
> 32-bit arithmetic, and then used in a context expecting a "uint64_t".
> Add a uint64_t cast.
>
> Fixes: Coverity CID 1519049
> Fixes: b68147b7a5bf ("ppc/xive: Add support for the PC MMIOs")
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>
> ---
>
> v2: removed extra space after cast
>
> hw/intc/pnv_xive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c
> index 9b10e905195a..bda3478b1f84 100644
> --- a/hw/intc/pnv_xive.c
> +++ b/hw/intc/pnv_xive.c
> @@ -210,7 +210,7 @@ static uint64_t pnv_xive_vst_addr_remote(PnvXive *xive, uint32_t type,
> return 0;
> }
>
> - remote_addr |= idx << xive->pc_shift;
> + remote_addr |= ((uint64_t)idx) << xive->pc_shift;
>
> vst_addr = address_space_ldq_be(&address_space_memory, remote_addr,
> MEMTXATTRS_UNSPECIFIED, &result);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-18 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 15:46 [PATCH v2] ppc/xive: Fix uint32_t overflow Cédric Le Goater
2023-09-18 10:32 ` Daniel Henrique Barboza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).