From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19EC5C7EE23 for ; Mon, 5 Jun 2023 14:08:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6AsG-000242-F2; Mon, 05 Jun 2023 10:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6AsE-00023Q-ET for qemu-devel@nongnu.org; Mon, 05 Jun 2023 10:07:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6AsC-0006xn-Em for qemu-devel@nongnu.org; Mon, 05 Jun 2023 10:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685974071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/upP/tE8jg6YR7b1hOTKfUt7DkXFgKajWHWbt9sogMI=; b=KL4EYm7Xa6E8JGv1UJB0Yz0ee1TQmNMDhiSw4/0x9AvsZT2/k3jHN5btVPnk/7O839lOq4 8ai3aREzQHe8YypdSRc2YmUBXZUqtPjD64SXTu8JzDN613rkmIWjL4CkqH4wu9v3Ol3HuL eiaRWw9nEmVA1csVE85YS99CA0L33Wo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-pxGo-TM5OU-NAxFWc7SYhw-1; Mon, 05 Jun 2023 10:07:50 -0400 X-MC-Unique: pxGo-TM5OU-NAxFWc7SYhw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30ae8776c12so2101083f8f.1 for ; Mon, 05 Jun 2023 07:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685974069; x=1688566069; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/upP/tE8jg6YR7b1hOTKfUt7DkXFgKajWHWbt9sogMI=; b=L0Y20yJgRbCbAYwkFov+ib/LxXA7PSxtKIa5UiaPwduVHdKofbQnxvZ11xw97aecMr skRMT66aDYbmbtomqQc7R3qpXTA8tv3h9ugktiMPT/reOA1UXGPuCq/plKJotOgVJfOR r+t+v5ezKCxspYlrtvdXwor5p48MUD/DjOPe1VM7rrpnx+UaZJUFeftGTqpw8Gy6Q6wt 2AtnfFy8F7IVjn5IUV52VtnaKfVYVcQFgftkgGMUZMXa7UUPiRti2wkW8HMhzQuqxWTD EPDwGQeqFUABKHfWuAWs9l4bEpLuRbdG6u30jDDPkL1fnJKsVn06qn3xJdz1+au8kJG1 997g== X-Gm-Message-State: AC+VfDzwBQ/B3Hy2Rqw2DgqZZolK/vwWVrgTiqMKcDj2sNGLuIRIQr5G SyJCNoCICYKLFIfcHnjXhDe/Z1zjhuXYgYAgCL2WuqBBbWMkyKoRKA/9DsDAPFQ9oxLHV4IFcMG Jz2bu+tbLKpPXEUo= X-Received: by 2002:a5d:664e:0:b0:307:8ea4:f8f5 with SMTP id f14-20020a5d664e000000b003078ea4f8f5mr5943504wrw.27.1685974069154; Mon, 05 Jun 2023 07:07:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5x07AhKFpVizKIwZ1D+/8IpJC3tEtRGEyKFvCaGgy1sAEzbXYXi+s5KdEFTyI9BBjJRH4Yag== X-Received: by 2002:a5d:664e:0:b0:307:8ea4:f8f5 with SMTP id f14-20020a5d664e000000b003078ea4f8f5mr5943487wrw.27.1685974068822; Mon, 05 Jun 2023 07:07:48 -0700 (PDT) Received: from [192.168.0.5] (ip-109-42-115-143.web.vodafone.de. [109.42.115.143]) by smtp.gmail.com with ESMTPSA id c4-20020a5d4144000000b0030ade1b9400sm9890063wrq.30.2023.06.05.07.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 07:07:48 -0700 (PDT) Message-ID: Date: Mon, 5 Jun 2023 16:07:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Cleber Rosa , Paolo Bonzini , John Snow , Laurent Vivier References: <20230601163123.1805282-1-berrange@redhat.com> From: Thomas Huth Subject: Re: [PATCH 0/6] tests: enable meson test timeouts to improve debuggability In-Reply-To: <20230601163123.1805282-1-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 01/06/2023 18.31, Daniel P. Berrangé wrote: > Perhaps the most painful of all the GitLab CI failures we see are > the enforced job timeouts: > > "ERROR: Job failed: execution took longer than 1h15m0s seconds" > > https://gitlab.com/qemu-project/qemu/-/jobs/4387047648 > > when that hits the CI log shows what has *already* run, but figuring > out what was currently running (or rather stuck) is an horrendously > difficult. > > The initial meson port disabled the meson test timeouts, in order to > limit the scope for introducing side effects from the port that would > complicate adoption. > > Now that the meson port is basically finished we can take advantage of > more of its improved features. It has the ability to set timeouts for > test programs, defaulting to 30 seconds, but overridable per test. This > is further helped by fact that we changed the iotests integration so > that each iotests was a distinct meson test, instead of having one > single giant (slow) test. > > We already set overrides for a bunch of tests, but they've not been > kept up2date since we had timeouts disabled. So this series first > updates the timeout overrides such that all tests pass when run in > my test gitlab CI pipeline. Then it enables use of meson timeouts. > > We might still hit timeouts due to non-deterministic performance of > gitlab CI runners. So we'll probably have to increase a few more > timeouts in the short term. Fortunately this is going to be massively > easier to diagnose. For example this job during my testing: > > https://gitlab.com/berrange/qemu/-/jobs/4392029495 > > we can immediately see the problem tests > > Summary of Failures: > 6/252 qemu:qtest+qtest-i386 / qtest-i386/bios-tables-test TIMEOUT 120.02s killed by signal 15 SIGTERM > 7/252 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test TIMEOUT 120.03s killed by signal 15 SIGTERM > 64/252 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test TIMEOUT 300.03s killed by signal 15 SIGTERM > > The full meson testlog.txt will show each individual TAP log output, > so we can then see exactly which test case we got stuck on. > > NB, the artifacts are missing on the job links above, until this > patch merges: > > https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04668.html > > NB, this series sets the migration-test timeout to 5 minutes, which > is only valid if this series is merged to make the migration test > not suck: > > https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg00286.html > > without that series, we'll need to set the migration-test timeout to > 30 minutes instead. > > Daniel P. Berrangé (6): > qtest: bump min meson timeout to 60 seconds > qtest: bump migration-test timeout to 5 minutes > qtest: bump qom-test timeout to 7 minutes > qtest: bump aspeed_smc-test timeout to 2 minutes > qtest: bump bios-table-test timeout to 6 minutes > mtest2make: stop disabling meson test timeouts > > scripts/mtest2make.py | 3 ++- > tests/qtest/meson.build | 16 ++++++---------- > 2 files changed, 8 insertions(+), 11 deletions(-) FWIW, I now ran this on my rather old laptop with an --enable-debug build with "make -j$(nproc) check-qtest" and got these additional failures (beside the expected migration-test that still needs its final speedup): qtest-aarch64/test-hmp TIMEOUT 120.07s killed by signal 15 SIGTERM qtest-aarch64/qom-test TIMEOUT 420.09s killed by signal 15 SIGTERM qtest-arm/qom-test TIMEOUT 420.10s killed by signal 15 SIGTERM qtest-arm/npcm7xx_pwm-test TIMEOUT 150.04s killed by signal 15 SIGTERM qtest-ppc64/pxe-test TIMEOUT 60.01s killed by signal 15 SIGTERM qtest-sparc/prom-env-test TIMEOUT 60.01s killed by signal 15 SIGTERM qtest-sparc/boot-serial-test TIMEOUT 60.01s killed by signal 15 SIGTERM When I run them manually without the timeout patch, I get these values: qtest-aarch64/test-hmp OK 168.66s 95 subtests passed qtest-aarch64/qom-test OK 646.37s 94 subtests passed qtest-arm/qom-test OK 621.64s 89 subtests passed qtest-arm/npcm7xx_pwm-test OK 225.48s 24 subtests passed qtest-ppc64/pxe-test OK 96.95s 2 subtests passed qtest-sparc/prom-env-test OK 95.94s 3 subtests passed qtest-sparc/boot-serial-test OK 92.96s 3 subtests passed HTH, Thomas