From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4735ECED606 for ; Tue, 18 Nov 2025 11:20:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLJkn-000630-1l; Tue, 18 Nov 2025 06:20:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLJkl-00062O-Iz for qemu-devel@nongnu.org; Tue, 18 Nov 2025 06:20:07 -0500 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vLJkj-0003sP-Tq for qemu-devel@nongnu.org; Tue, 18 Nov 2025 06:20:07 -0500 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-bd1b0e2c1eeso1434660a12.0 for ; Tue, 18 Nov 2025 03:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1763464804; x=1764069604; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y82gJCb1WhqG/etTGEMv1Gsg9yYTi7jDcVYkgk6cH7I=; b=ex/6KeiC10dAf5KJT44sNJlcZl+Vipev4fvKIWwRqBbs+/huOYe+70wbnl/MhBGHGz Mzr6UxpKUBrAQrAqYNeRE15xyFZsOAEKacxfOoyJfDwBzojlQRtU7NrBv560OyQjkUfZ e+2LfpmP+nB0xykNIXp5U6ob56Cu1swcHHBN5mlaM5oLNI5QJ+czX1jydU/jqY8MvknS ITtXml5wogDAjBy3hEeEcmwz/ZyGcXoVMUFrmYu7mU0j5Et278v3347PkKdTV4DI/IV4 vYmpn3g3AMdSX0zNz59YP2Ex2MorTe91oQRI9Ed8ZKaUrOtfsbvuEeMByLB5g1VXNKhb UvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763464804; x=1764069604; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y82gJCb1WhqG/etTGEMv1Gsg9yYTi7jDcVYkgk6cH7I=; b=OoefvlLeJWnbnAxCnmyDJ1pDwx1PoQNoMsmNL8UkzLSDne+4TmGhUDt5suVqGieD5A JDtwZh+MoGVGKHbYDypVZkmuUsFm5THA0t4HXxN+wyz3YXapNdtQQ31FoweTmIE0AM4i w9Sx5h6BXon39kpWCn+nc/LADcEamtnW9DRZuAv73R1GGY9myvm97Lvdr7iXX7MOAq7D 6f/uSpujpqxFbipZyy0Qx58fLwVFwgaeniFVYNr+xPFcHpOPW6t9wVuTQlQ8Hy3s6yx4 Pc/n8MpAQYumSU5VxFzlfWUHZxNdowFTnWkrD/ky1zrq56xaWvDRhvUpcf20XNNgNN6g bEzg== X-Forwarded-Encrypted: i=1; AJvYcCUbXYXGvhhoukhDmekjQSR8Ian/A6Yp/moGiYiOEfDa1Do4ZjltVgxUAcEMGh6vAaeHscpg9xkuh1gk@nongnu.org X-Gm-Message-State: AOJu0YzD0M6BjVGlVLk94CmlRFPCIVj1SY5KsM3/rcOwhEBmY6tkjbkA +IRam3KZ/Ab82O3iBAkfWWagwz9copigL0SBDjjQ5qPg/uU/7wIb4lCEEMd8n04DNz4= X-Gm-Gg: ASbGncsH7s0/fWkuqYmQfhOCLjAIPFyJk+MhOnFTk6ew0PlupeoalkJl7630unysK/A M2s5EJVn89upjy+geacnfGh3voqc0y4OjxIogKxzo0bQkxAFegNHTDSnYzEek12IXtSfJCTdMJp bRzPBH41vh1c2TgwDX4qah0cZi9t8WbDeoBaYWcSoAIQNABXoj2nfopzrPOxQEAwMO94enoWz4/ I3tQqPCTsAqF7WFvEJP41crmPstd41ONebXyUYiHbyqVpLGuZ59eXQY8QaMj6mqTa9nUxt2NXNK T+8IUC+n6fZQcp1M5rC+yS4tP3rpuxGk31mbLqWEo5/HgzPoRCTBtz2d4OyFb9Fss7yvdZ/xjC/ +kJTSQbI+eRKsSXOWQlrwzza6VzMAfPrGGGKpMJa25d1vj26uz5LcYrwf62zYEGyjyacQJZ3jvs RSIAuDgg8IcXQbYdcXYj8wEfcqF3W8PH18an08 X-Google-Smtp-Source: AGHT+IFWDkFXf7R5qiT1nXpTOWN0wu16B3YB5+GY7s0+Xm56F3cjFKUhpMFZrs5vbtRwVmQPzY0UDw== X-Received: by 2002:a05:7300:570e:b0:2a4:3593:c7c8 with SMTP id 5a478bee46e88-2a4aba9906emr7337760eec.8.1763464803566; Tue, 18 Nov 2025 03:20:03 -0800 (PST) Received: from [192.168.68.110] ([191.202.237.26]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db4a36asm44104067eec.5.2025.11.18.03.20.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 03:20:03 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 08:19:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] target/riscv: fix address masking To: frank.chang@sifive.com, qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Weiwei Li , Liu Zhiwei , "open list:RISC-V TCG CPUs" , Yong-Xuan Wang References: <20251118105936.2839054-1-frank.chang@sifive.com> <20251118105936.2839054-2-frank.chang@sifive.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20251118105936.2839054-2-frank.chang@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=dbarboza@ventanamicro.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/18/25 7:59 AM, frank.chang@sifive.com wrote: > From: Yong-Xuan Wang > > The pmlen should get the corresponding value before shifting address. > > Signed-off-by: Yong-Xuan Wang > Reviewed-by: Frank Chang > --- Reviewed-by: Daniel Henrique Barboza > target/riscv/internals.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/internals.h b/target/riscv/internals.h > index 172296f12e2..9b3f01144d2 100644 > --- a/target/riscv/internals.h > +++ b/target/riscv/internals.h > @@ -203,8 +203,8 @@ static inline target_ulong adjust_addr_body(CPURISCVState *env, > if (!is_virt_addr) { > signext = riscv_cpu_virt_mem_enabled(env); > } > - addr = addr << pmlen; > pmlen = riscv_pm_get_pmlen(pmm); > + addr = addr << pmlen; > > /* sign/zero extend masked address by N-1 bit */ > if (signext) {