qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH] roms: Add a 'make help' target alias
Date: Tue, 24 Sep 2019 17:55:27 +0200	[thread overview]
Message-ID: <a0c746cb-c39b-32b4-3635-3e0c6cbd2b14@redhat.com> (raw)
In-Reply-To: <20190920171159.18633-1-philmd@redhat.com>

On 09/20/19 19:11, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
> 
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>  
> -default:
> +default help:
>  	@echo "nothing is build by default"
>  	@echo "available build targets:"
>  	@echo "  bios               -- update bios.bin (seabios)"
> 

How about we just print: "help yourself"?

Just kidding. :P

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo


      parent reply	other threads:[~2019-09-24 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 17:11 [PATCH] roms: Add a 'make help' target alias Philippe Mathieu-Daudé
2019-09-20 17:13 ` Peter Maydell
2019-09-20 17:36 ` John Snow
2019-09-24 15:55 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0c746cb-c39b-32b4-3635-3e0c6cbd2b14@redhat.com \
    --to=lersek@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).