Re: [PULL 04/12] tests/functional: Test whether the vmstate-static-checker script works fine

[Thomas Huth <thuth@redhat.com>]

On 29/10/2025 12.58, Daniel P. Berrangé wrote:
> On Wed, Sep 24, 2025 at 08:39:48AM +0200, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> We've got two vmstate dump files in the repository which are meant
>> for verifying whether the vmstate-static-checker.py works as expected.
>> Since running this manually is a cumbersome job, let's add an automated
>> test for this instead that runs the script with the two dump files
>> and checks for the expected output.
> 
> This job always fails on Fedora 43, because the vmstate script
> output includes python deprecation warnings:
> 
>    2025-10-29 11:53:55,097 - INFO: vmstate-static-checker output:
>    /var/home/berrange/src/virt/qemu/tests/functional/../../scripts/vmstate-static-checker.py:385: PendingDeprecationWarning: FileType is deprecated. Simply open files after parsing arguments.
>      parser.add_argument('-s', '--src', type=argparse.FileType('r'),
>    /var/home/berrange/src/virt/qemu/tests/functional/../../scripts/vmstate-static-checker.py:388: PendingDeprecationWarning: FileType is deprecated. Simply open files after parsing arguments.
>      parser.add_argument('-d', '--dest', type=argparse.FileType('r'),

Thanks for the heads-up, I guess we should now rather use type=pathlib.Path 
in this script instead. I'll try to come up with a patch...

  Thomas