From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns
Date: Thu, 14 Dec 2017 12:22:47 -0500 [thread overview]
Message-ID: <a0cb18cf-61b1-a18a-d2b0-4a536aca51e2@redhat.com> (raw)
In-Reply-To: <b0969a32-fa45-a4f5-0768-959750622698@redhat.com>
On 12/14/2017 12:21 PM, Paolo Bonzini wrote:
> On 14/12/2017 17:06, John Snow wrote:
>>>
>>> And another question. After this series there is exactly one
>>> block_job_sleep_ns call (in block/mirror.c). Perhaps instead of
>>> block_job_throttle, you should refine block_job_sleep_ns?
>>>
>> Yeah, maybe? "A rose by any other name," though -- I think I might be
>> coming for the block/mirror call next because I have one more downstream
>> BZ that references this as a job that can cause the warning print.
>>
>> So maybe we'll just have throttle calls instead of sleep calls from here
>> on out.
>
> Ok, shall we wait for v2 where you look at that BZ as well?
>
> Thanks,
>
> Paolo
>
Sure -- if the only feedback you have on this series is primarily style
and "maybe there are some more wins" I can spin a v2 to try to broaden
the scope if it looks good so far.
--js
next prev parent reply other threads:[~2017-12-14 17:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 0:59 [Qemu-devel] [PATCH 0/7] blockjob: refactor mirror_throttle John Snow
2017-12-14 0:59 ` [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield John Snow
2017-12-14 8:38 ` Paolo Bonzini
2017-12-14 15:55 ` John Snow
2017-12-18 14:22 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition John Snow
2017-12-14 8:51 ` Paolo Bonzini
2017-12-18 14:23 ` Stefan Hajnoczi
2018-01-02 20:29 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle John Snow
2017-12-14 8:39 ` Paolo Bonzini
2017-12-14 15:57 ` John Snow
2017-12-18 14:27 ` Stefan Hajnoczi
2018-01-02 21:23 ` Jeff Cody
2017-12-14 0:59 ` [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns John Snow
2017-12-14 8:49 ` Paolo Bonzini
2017-12-14 16:06 ` John Snow
2017-12-14 17:21 ` Paolo Bonzini
2017-12-14 17:22 ` John Snow [this message]
2017-12-14 17:23 ` Paolo Bonzini
2017-12-14 0:59 ` [Qemu-devel] [PATCH 5/7] block/commit: use block_job_throttle John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 6/7] block/stream: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
2017-12-14 0:59 ` [Qemu-devel] [PATCH 7/7] block/backup: " John Snow
2017-12-14 8:50 ` Paolo Bonzini
2017-12-18 14:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0cb18cf-61b1-a18a-d2b0-4a536aca51e2@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).