From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bozpf-0001h8-19 for qemu-devel@nongnu.org; Tue, 27 Sep 2016 17:22:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bozpa-0007Cs-SZ for qemu-devel@nongnu.org; Tue, 27 Sep 2016 17:22:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bozpa-0007Cc-ML for qemu-devel@nongnu.org; Tue, 27 Sep 2016 17:22:26 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15E6683E for ; Tue, 27 Sep 2016 21:22:26 +0000 (UTC) References: <1475002565-30170-1-git-send-email-dgilbert@redhat.com> From: John Snow Message-ID: Date: Tue, 27 Sep 2016 17:22:25 -0400 MIME-Version: 1.0 In-Reply-To: <1475002565-30170-1-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Add error reporting in migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org, amit.shah@redhat.com, quintela@redhat.com On 09/27/2016 02:56 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > At the moment if you use a VMSTATE_*_EQUAL macro and the value > doesn't match you just get an error about the section that failed > > e.g. > qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' > qemu-system-ppc64: load of migration failed: Invalid argument > > with this pair you get the field and the mismatched values. > e.g. > qemu-system-ppc64: 8000600FE1FF7AE1 != 8000600FE1FF3A21 > qemu-system-ppc64: Failed to load cpu:env.insns_flags > qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' > qemu-system-ppc64: load of migration failed: Invalid argument > > which is much more likely to point you at the culprit. > > (Broken out from a larger vmstatification series, the only change since > then is the values are printed in hex except for the le case). > > Dave > > Dr. David Alan Gilbert (2): > migration: report an error giving the failed field > migration: Report values for comparisons > > migration/vmstate.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > I see this as a strict improvement; though I don't know if there will be complaints about printing error messages instead of adding pathways for the Error object. Meh. Existing errors here simply use error_report anyway, so: Reviewed-by: John Snow