From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98D14C87FCB for ; Mon, 4 Aug 2025 22:44:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uj3vE-0002Lv-V3; Mon, 04 Aug 2025 18:44:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uj3uF-00021o-Ud for qemu-devel@nongnu.org; Mon, 04 Aug 2025 18:43:49 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uj3uD-0003qm-D2 for qemu-devel@nongnu.org; Mon, 04 Aug 2025 18:43:46 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-24063eac495so28609665ad.0 for ; Mon, 04 Aug 2025 15:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754347424; x=1754952224; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8sn06oDs9DeCnEOpA36nFRdaDNe3BvouVSVNqYHrrMc=; b=y3/0mMXOT6Fu302e54tv0bi2loabko3KBOD1+Qg+x6EBYPnTRLjWKPkWSzMyzpWGEQ vDbXdEOW7Czxk9TgbdlvjAYOtf3YFxuLJGFWSxuSOAmSnA0Ol4gtNkumvj2Oe2Lz7Knt g6DVUbkipcsXQxBC/HTXApqnC83vF+3AxfpGPkxbXgvJ+XDUzY0+Q9dWHjjOz3t0ahum elr4PdSHGp/Yn4u8XyxHY4HlBZiLoXuaOUm5RoLJaXhxRMfgR55J+7Al0Dx2Xxsw6qNl gkfe38nOTKLI3sRmrFDHTTVufRNT8rEUA3YmZ3/JrTcGRZnrPxF/4nzUlggigl5eHrL9 6h0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754347424; x=1754952224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8sn06oDs9DeCnEOpA36nFRdaDNe3BvouVSVNqYHrrMc=; b=L64lLe9UDBcHbsMkqH8LHiw91d6lqDsKnQP50AbKNLT9BZTkzO6Ck/hbOcYsVUwNso 13vNe4crNJxwiOISQzPCl+oS0Z47sxfcr8gjLjV6j8h86vMEi9KO3qjlfca7d3bCB2dU iMDUrEvlwYoMQgrvNpyJZGTqPeMOtabJOEn3auZNbJDU8jUQrw9WUmd0fW/fkmLnTB7x EEGX2bX19iZSOuFm3tmTMpF55VK3jEuQmsQa/n4I1FV/HalANMFsyKPdaO4NjrlG2qC+ aXxpUww0/+vyPjK8W0Foe/PI8uwu+83Hdvt2x31V4XGgy2/WdctXsHaQVjSVNwIJXD+F EbFA== X-Forwarded-Encrypted: i=1; AJvYcCUX7hIJhcq6Ugi3wrbr/DZk3hHLVCseHBcFzhsKblMleV29rh5uTLgwzGVRbSUV6CxHdpp12JpjiyMo@nongnu.org X-Gm-Message-State: AOJu0YwM9mNOTIjc+wzA5AWch4s6eHWTT0biu3UCMGvRQjfLwvdY0SBp Ap3DfjfnsHrcQMWVG19cHipEkFDKsjqtFFdbkd8np8Z8UiUGuQ03rA/NgWsLhwuxfnE= X-Gm-Gg: ASbGncvnz5+zIoYs3fbuiVD87h0JULWK4WdTY5eviNe2oYwZZAH8tHifkb3KpdD2CLP 9WBcFPcUx7S7q1pgi/z+vdmRh7OCZbWJfzhk1y+tFHFbkvfag/t9FOgU3bz4I9ZwaqUEPW0j1nP l6rl8vh0cEet1OI4jSFiyX76avZb8aOi2ghBMvrQj5jwIMHseO13FVIecGORcFOnPCzvlKVuugf ZgoyuqIKLufHGDTHxsj5F2FC790dXavk3paFbqLaqsmSXVN8LxWY4qwPX6xhJs4yaoo95/dhR8X soGUXnQERxErfnMMR1gpIxhQnCWSt+Yf0sQ73/xc8rQWGdSOxt/D6NCa8wX0CeqeZSobf8qHsCh MHlztMe/rComnamX3inD4N9XN68CDIQw44QY= X-Google-Smtp-Source: AGHT+IHqBOGU26KiM30/Bpq7wP8OjuWKTMYsYwbRWPyO8L1h/C1CDXl6pjHCma2VWvOP7FTxpfEg4w== X-Received: by 2002:a17:902:f54f:b0:23f:df56:c74c with SMTP id d9443c01a7336-24246f5e4abmr149500795ad.14.1754347423943; Mon, 04 Aug 2025 15:43:43 -0700 (PDT) Received: from [192.168.1.87] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1f22788sm119253965ad.74.2025.08.04.15.43.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 15:43:43 -0700 (PDT) Message-ID: Date: Mon, 4 Aug 2025 15:43:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/12] semihosting/arm-compat-semi: replace target_ulong with uint64_t To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, Weiwei Li , Palmer Dabbelt , richard.henderson@linaro.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Peter Maydell , Liu Zhiwei , qemu-arm@nongnu.org, Alistair Francis , Daniel Henrique Barboza References: <20250804183950.3147154-1-pierrick.bouvier@linaro.org> <20250804183950.3147154-10-pierrick.bouvier@linaro.org> Content-Language: en-US From: Pierrick Bouvier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/4/25 3:42 PM, Philippe Mathieu-Daudé wrote: > Hi Pierrick, > > On 4/8/25 20:39, Pierrick Bouvier wrote: >> Reviewed-by: Richard Henderson >> Signed-off-by: Pierrick Bouvier >> --- >> semihosting/arm-compat-semi.c | 24 ++++++++++++------------ >> 1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c >> index c03096b253d..f593239cc9a 100644 >> --- a/semihosting/arm-compat-semi.c >> +++ b/semihosting/arm-compat-semi.c >> @@ -123,7 +123,7 @@ static GuestFD console_out_gf; >> */ >> >> typedef struct LayoutInfo { >> - target_ulong rambase; >> + vaddr rambase; > > Subject says uint64_t but code use vaddr, is that expected? > I didn't update description since last version, indeed, should be vaddr. >> size_t ramsize; >> hwaddr heapbase; >> hwaddr heaplimit; > > >> @@ -300,9 +300,9 @@ static void common_semi_seek_cb(CPUState *cs, uint64_t ret, int err) >> * is defined by GDB's remote protocol and is not target-specific.) >> * We put this on the guest's stack just below SP. >> */ >> -static target_ulong common_semi_flen_buf(CPUState *cs) >> +static uint64_t common_semi_flen_buf(CPUState *cs) >> { >> - target_ulong sp = common_semi_stack_bottom(cs); >> + vaddr sp = common_semi_stack_bottom(cs); > > Ditto. > >> return sp - 64; >> } >