From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC860C433DB for ; Tue, 16 Feb 2021 10:58:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8396664D9F for ; Tue, 16 Feb 2021 10:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8396664D9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBy3R-0000VI-Fm for qemu-devel@archiver.kernel.org; Tue, 16 Feb 2021 05:58:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBxvK-0007Mt-7U for qemu-devel@nongnu.org; Tue, 16 Feb 2021 05:49:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBxvI-0007Gv-Jv for qemu-devel@nongnu.org; Tue, 16 Feb 2021 05:49:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613472579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irx30eBMANQXeuqbnjT81MsTSgUzHfdVUFM1EItoh6U=; b=VI4nGzpwFi90oJgX1S8qIJhgFXx1oyETudw4uDuIk4r3zvkGK0ELOCf4Wh+7zcxOZjhwmJ BnQT7FwlilJlBUkVo7cwFV/2GPuy21HmXd4uggq2kROFRVIiOUT7EJnxgTcg8nTa01Es6I UQnmeO3jdShQsmhZBJIma75o+URn9AE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-7v345EBsOuuZ3kq3EgcWnQ-1; Tue, 16 Feb 2021 05:49:36 -0500 X-MC-Unique: 7v345EBsOuuZ3kq3EgcWnQ-1 Received: by mail-wr1-f71.google.com with SMTP id b3so8330180wro.8 for ; Tue, 16 Feb 2021 02:49:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=irx30eBMANQXeuqbnjT81MsTSgUzHfdVUFM1EItoh6U=; b=CgnwlmowSFXXJ2s1XIEqk/eCzH2WjePMqjfE9RfkmbYpiT0nkyZuGcviKnw8K2RGPP teC6udulVCt0IXIS935ACm2rBMcEe/ql6bJerC7RCxS/Mkr0CuX0Fj9+hygNhWTM4q6O ydompjXeCfBAQt7yJpQrihhtkqWMq5q2rZBYHB6fBb3LSMkFIxF5JAHcUGkuSW/ZFYY7 x3JZSOdusa7Ksa1qc5FEDwHICx9cALuYpVMQ7iejZhIrCmyC9s7wg5JyigrykHP0pwAN yDqV0KgRhfGG6CYBgAicaxZKZjP4bH+p7IJ70y9DxCoTtmFoa+26ZZsQJK8NVBeG7UnI tymQ== X-Gm-Message-State: AOAM531oFKn+rZqjfF0IALMwb1PoeASGQn7paQ/Rgyjhn3pbGNbw7HGk 0eYamfsy62Kto4c4iHSPD3kK0HyhVvitvQQ6GbMtRV2i5zx6GOvQ067fpzFEGLtl9n5oWgtRYw/ aaxVGc4hGbqgdVfM= X-Received: by 2002:a1c:48c4:: with SMTP id v187mr2713126wma.145.1613472574930; Tue, 16 Feb 2021 02:49:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwupi83f77z+oEZ3f2IjBl6SSByYiY5xBmI8kwocZBtdMNEYonSU0wJNC5DBBS2nbfuSBMX8g== X-Received: by 2002:a1c:48c4:: with SMTP id v187mr2713116wma.145.1613472574757; Tue, 16 Feb 2021 02:49:34 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x13sm3195257wmc.27.2021.02.16.02.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Feb 2021 02:49:34 -0800 (PST) Subject: Re: [PATCH v2] meson.build: expose TCG cross compiler information in summary To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20210216102522.6279-1-alex.bennee@linaro.org> From: Paolo Bonzini Message-ID: Date: Tue, 16 Feb 2021 11:49:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210216102522.6279-1-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f4bug@amsat.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/02/21 11:25, Alex Bennée wrote: > Blink and you miss the cross TCG compiler stuff so lets display it > with the rest of the compiler information. > > Signed-off-by: Alex Bennée > > --- > v2 > - use target_dirs/fs.exists() instead of find Acked-by: Paolo Bonzini Using $(wildcard) could be better than TARGET_DIRS in tests/Makefile.include, too, something like this: diff --git a/tests/Makefile.include b/tests/Makefile.include index d34254fb29..7203243b08 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -41,7 +41,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \ SPEED = quick # Build up our target list from the filtered list of ninja targets -TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, $(ninja-targets))) +TARGETS=$(patsubst tests/tcg/config-%.mak, %, $(wildcard tests/tcg/config-target.mak)) # Per guest TCG tests BUILD_TCG_TARGET_RULES=$(patsubst %,build-tcg-tests-%, $(TARGETS)) @@ -49,7 +49,7 @@ CLEAN_TCG_TARGET_RULES=$(patsubst %,clean-tcg-tests-%, $(TARGETS)) RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, $(TARGETS)) # Probe for the Docker Builds needed for each build -$(foreach PROBE_TARGET,$(TARGET_DIRS), \ +$(foreach PROBE_TARGET,$(TARGETS), \ $(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs)) $(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if $(CONFIG_PLUGIN),test-plugins) I'll test it and send it out. Paolo