From: Paolo Bonzini <pbonzini@redhat.com>
To: Yury Kotov <yury-kotov@yandex-team.ru>,
Richard Henderson <rth@twiddle.net>
Cc: Stefan Weil <sw@weilnetz.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"open list:Overall" <qemu-devel@nongnu.org>,
"yc-core@yandex-team.ru" <yc-core@yandex-team.ru>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop
Date: Mon, 15 Jul 2019 14:54:37 +0200 [thread overview]
Message-ID: <a0dc0747-27e9-6868-7fcb-6ebf9f797ecf@redhat.com> (raw)
In-Reply-To: <1198471563194184@iva8-147456c4bd40.qloud-c.yandex.net>
On 15/07/19 14:36, Yury Kotov wrote:
> Sorry, perhaps I was not accurate enough.
>
> To fix the bug I changed the logic of cpu_throttle_thread() function.
> Before this function called qemu_mutex_(un)lock_iothread which encapsulates
> work with qemu_global_mutex.
>
> Now, this calls qemu_cond_timedwait(..., &qemu_global_mutex, ...) which also
> unlocks/locks qemu_global_mutex. But, in theory, behavior of
> qemu_mutex_(un)lock_iothread may differ from simple locking/unlocking of
> qemu_global_mutex.
>
> So, I'm not sure is such change is ok or not.
Ah, I see. No, it's okay. The only difference is setting/clearing
iothread_locked which doesn't matter here.
Paolo
next prev parent reply other threads:[~2019-07-15 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 9:23 [Qemu-devel] [RFC PATCH 0/2] High downtime with 95+ throttle pct Yury Kotov
2019-07-10 9:23 ` [Qemu-devel] [RFC PATCH 1/2] qemu-thread: Add qemu_cond_timedwait Yury Kotov
2019-07-10 9:23 ` [Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop Yury Kotov
2019-07-15 9:40 ` Yury Kotov
2019-07-15 11:00 ` Paolo Bonzini
2019-07-15 12:36 ` Yury Kotov
2019-07-15 12:54 ` Paolo Bonzini [this message]
2019-07-10 9:56 ` [Qemu-devel] [RFC PATCH 0/2] High downtime with 95+ throttle pct Dr. David Alan Gilbert
2019-07-10 10:24 ` Yury Kotov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0dc0747-27e9-6868-7fcb-6ebf9f797ecf@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=yc-core@yandex-team.ru \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).