From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: David Brenken <david.brenken@efs-auto.org>, qemu-devel@nongnu.org
Cc: David Brenken <david.brenken@efs-auto.de>
Subject: Re: [Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks
Date: Tue, 20 Feb 2018 16:48:09 +0100 [thread overview]
Message-ID: <a0e36eca-d274-4041-aedf-14fc61b0c251@mail.uni-paderborn.de> (raw)
In-Reply-To: <20180219061827.2112-1-david.brenken@efs-auto.org>
Hi David,
On 02/19/2018 07:18 AM, David Brenken wrote:
> From: David Brenken <david.brenken@efs-auto.de>
>
> Hello,
>
> this is my first commit of a patch set for QEMU.
welcome aboard and thanks for your first patchset. So far it looks good
to me and I will definitively accept it. However, I still have some
comments regarding some of the patches, which you need to address. I in
lined the comments into the mail containing the patch.
Cheers,
Bastian
prev parent reply other threads:[~2018-02-20 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 6:18 [Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks David Brenken
2018-02-19 6:18 ` [Qemu-devel] [PATCH 1/5] tricore: added some missing cpu instructions David Brenken
2018-02-20 15:48 ` Bastian Koppelmann
2018-02-19 6:18 ` [Qemu-devel] [PATCH 2/5] tricore: added CORE_ID David Brenken
2018-02-20 15:53 ` Bastian Koppelmann
2018-02-19 6:18 ` [Qemu-devel] [PATCH 3/5] tricore: fixed wrong masking of IE David Brenken
2018-02-20 15:59 ` Bastian Koppelmann
2018-02-19 6:18 ` [Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE David Brenken
2018-02-20 16:03 ` Bastian Koppelmann
2018-02-19 6:18 ` [Qemu-devel] [PATCH 5/5] tricore: fixed wrong shifting of PCXI PIE David Brenken
2018-02-20 15:48 ` Bastian Koppelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e36eca-d274-4041-aedf-14fc61b0c251@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=david.brenken@efs-auto.de \
--cc=david.brenken@efs-auto.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).