From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PULL v4 00/25] Misc patches for 2022-04-29
Date: Thu, 5 May 2022 19:19:18 +0200 [thread overview]
Message-ID: <a0e6e14f-5326-be45-2f6a-41da01ea05fd@redhat.com> (raw)
In-Reply-To: <8fd8cf3b-08f5-3666-edac-2dec322e88b0@linaro.org>
On 5/5/22 17:17, Richard Henderson wrote:
> In file included from
> /home/gitlab-runner/builds/Jpwtyaz7/0/qemu-project/qemu/include/qemu/osdep.h:30,
>
> from ../block.c:26:
> ../block.c: In function ‘bdrv_format_is_whitelisted’:
> ./config-host.h:44:163: error: called object is not a function or
> function pointer
> #define CONFIG_BDRV_RW_WHITELIST "qcow2", "raw", "file",
> "host_device", "nbd", "iscsi", "rbd", "blkdebug", "luks", "null-co",
> "nvme", "copy-on-read", "throttle", "gluster"
>
> ^~~~~~~~~
> ../block.c:478:9: note: in expansion of macro ‘CONFIG_BDRV_RW_WHITELIST’
> CONFIG_BDRV_RW_WHITELIST
> ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from
> /home/gitlab-runner/builds/Jpwtyaz7/0/qemu-project/qemu/include/qemu/osdep.h:30,
>
> from ../block.c:26:
> ./config-host.h:42:66: error: called object is not a function or
> function pointer
> #define CONFIG_BDRV_RO_WHITELIST "vmdk", "vhdx", "vpc", "https", "ssh"
> ^~~~~
> ../block.c:482:9: note: in expansion of macro ‘CONFIG_BDRV_RO_WHITELIST’
> CONFIG_BDRV_RO_WHITELIST
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2418086124
I'm really sorry. At least this should have been caught by the
contributor CI though, I'll send a patch.
Paolo
prev parent reply other threads:[~2022-05-05 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 21:06 [PULL v4 00/25] Misc patches for 2022-04-29 Paolo Bonzini
2022-05-04 21:06 ` [PULL 19/25] build: move vhost-vsock configuration to Kconfig Paolo Bonzini
2022-05-05 15:17 ` [PULL v4 00/25] Misc patches for 2022-04-29 Richard Henderson
2022-05-05 17:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e6e14f-5326-be45-2f6a-41da01ea05fd@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).