From: Richard Henderson <richard.henderson@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] linux-user: Avoid mmap of the last byte of the reserved_va
Date: Sat, 1 Jul 2023 08:59:13 +0200 [thread overview]
Message-ID: <a0f19d7b-789c-cd97-6b5c-9b9630b62cff@linaro.org> (raw)
In-Reply-To: <48a6d541-4edf-4738-1ca9-34cab29a8bdc@tls.msk.ru>
On 6/30/23 18:06, Michael Tokarev wrote:
> 29.06.2023 11:08, Richard Henderson wrote:
>> There is an overflow problem in mmap_find_vma_reserved:
>> when reserved_va == UINT32_MAX, end may overflow to 0.
>> Rather than a larger rewrite at this time, simply avoid
>> the final byte of the VA, which avoids searching the
>> final page, which avoids the overflow.
>
> This hack appears to fix known issues and apparently does not
> introduce regressions.
>
> Can it be applied to master and picked up from there, since
> master is also broken? You can revert it in the subsequent
> patchset like the one you posted today.
>
> You can add my:
>
> Tested-by: Michael Tokarev <mjt@tls.msk.ru>
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Yes, that's a good idea. Queued to tcg-next.
r~
prev parent reply other threads:[~2023-07-01 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 8:08 [PATCH] linux-user: Avoid mmap of the last byte of the reserved_va Richard Henderson
2023-06-29 21:27 ` Michael Tokarev
2023-06-30 16:06 ` Michael Tokarev
2023-07-01 6:59 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f19d7b-789c-cd97-6b5c-9b9630b62cff@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).