Re: [PULL 00/21] Migration 20230530 patches

[Richard Henderson <richard.henderson@linaro.org>]

On 5/30/23 04:54, Juan Quintela wrote:
> The following changes since commit aa9bbd865502ed517624ab6fe7d4b5d89ca95e43:
> 
>    Merge tag 'pull-ppc-20230528' ofhttps://gitlab.com/danielhb/qemu  into staging (2023-05-29 14:31:52 -0700)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/juan.quintela/qemu.git  tags/migration-20230530-pull-request
> 
> for you to fetch changes up to d83da4626ebc1462e8f0065d446f97aece681d90:
> 
>    migration/rdma: Check sooner if we are in postcopy for save_page() (2023-05-30 13:27:54 +0200)
> 
> ----------------------------------------------------------------
> Migration 20230530 Pull request
> 
> Hi
> 
> On this PULL request:
> 
> - Set vmstate migration failure right (vladimir)
> - Migration QEMUFileHook removal (juan)
> - Migration Atomic counters (juan)
> 
> Please apply.

Fails immediately:

In file included from ../src/migration/ram.c:61:
../src/migration/rdma.h:52:5: error: no previous prototype for ‘rdma_registration_handle’ 
[-Werror=missing-prototypes]
    52 | int rdma_registration_handle(QEMUFile *f) { return 0; }
       |     ^~~~~~~~~~~~~~~~~~~~~~~~
../src/migration/rdma.h:53:5: error: no previous prototype for ‘rdma_registration_start’ 
[-Werror=missing-prototypes]
    53 | int rdma_registration_start(QEMUFile *f, uint64_t flags) { return 0; }
       |     ^~~~~~~~~~~~~~~~~~~~~~~
../src/migration/rdma.h:54:5: error: no previous prototype for ‘rdma_registration_stop’ 
[-Werror=missing-prototypes]
    54 | int rdma_registration_stop(QEMUFile *f, uint64_t flags) { return 0; }
       |     ^~~~~~~~~~~~~~~~~~~~~~
../src/migration/rdma.h:55:5: error: no previous prototype for 
‘rdma_block_notification_handle’ [-Werror=missing-prototypes]
    55 | int rdma_block_notification_handle(QEMUFile *f, const char *name) { return 0; }
       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/migration/rdma.h:56:5: error: no previous prototype for ‘rdma_control_save_page’ 
[-Werror=missing-prototypes]
    56 | int rdma_control_save_page(QEMUFile *f, ram_addr_t block_offset,
       |     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


r~