From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwUQj-0005IZ-Hf for qemu-devel@nongnu.org; Mon, 25 Sep 2017 10:32:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwUQf-00071w-IA for qemu-devel@nongnu.org; Mon, 25 Sep 2017 10:32:17 -0400 References: <20170710163029.129912-1-vsementsov@virtuozzo.com> <20170710163029.129912-4-vsementsov@virtuozzo.com> <20170711130650.GD2223@work-vm> <2394bb38-de82-8621-eeae-14ffea68869b@virtuozzo.com> <1078f013-e554-1d75-d1e8-f24daace5965@virtuozzo.com> <20170919190634.GK2107@work-vm> <87bmm5k2zs.fsf@secure.laptop> <20170925132312.GA7999@localhost.localdomain> From: Vladimir Sementsov-Ogievskiy Message-ID: Date: Mon, 25 Sep 2017 17:31:44 +0300 MIME-Version: 1.0 In-Reply-To: <20170925132312.GA7999@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] ping Re: [PATCH v7 03/16] migration: split common postcopy out of ram postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Juan Quintela Cc: "Dr. David Alan Gilbert" , peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com, lirans@il.ibm.com, pbonzini@redhat.com, den@openvz.org, mreitz@redhat.com, John Snow 25.09.2017 16:23, Kevin Wolf wrote: > Am 20.09.2017 um 13:45 hat Juan Quintela geschrieben: >> "Dr. David Alan Gilbert" wrote: >>> * Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote: >>>> ping for 1-3 >>>> Can we merge them? >>> I see all of them have R-b's; so lets try and put them in the next >>> migration merge. >>> >>> Quintela: Sound good? >> Yeap. > This patch broke qemu-iotests 181 ('Test postcopy live migration with > shared storage'): > > --- /home/kwolf/source/qemu/tests/qemu-iotests/181.out 2017-06-16 19:19:53.000000000 +0200 > +++ 181.out.bad 2017-09-25 15:20:40.787582000 +0200 > @@ -21,18 +21,16 @@ > === Do some I/O on the destination === > > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) qemu-io disk "read -P 0x55 0 64k" > +(qemu) QEMU_PROG: Expected vmdescription section, but got 0 > +QEMU_PROG: Failed to get "write" lock > +Is another process using the image? > +qemu-io disk "read -P 0x55 0 64k" > read 65536/65536 bytes at offset 0 > 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > (qemu) > (qemu) qemu-io disk "write -P 0x66 1M 64k" > -wrote 65536/65536 bytes at offset 1048576 > -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > - > -=== Shut down and check image === > - > -(qemu) quit > -(qemu) > -(qemu) quit > -No errors were found on the image. > -*** done > +QEMU_PROG: block/io.c:1359: bdrv_aligned_pwritev: Assertion `child->perm & BLK_PERM_WRITE' failed. > +./common.config: Aborted (core dumped) ( if [ -n "${QEMU_NEED_PID}" ]; then > +echo $BASHPID > "${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid"; > +fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" ) > +Timeout waiting for ops/sec on handle 1 Not sure about locking (don't see this error on my old kernel without OFD locking), but it looks like that 181 test should be fixed to set postcopy-ram capability on target too (which was considered as correct way on list) -- Best regards, Vladimir