From: John Snow <jsnow@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp
Date: Mon, 7 Aug 2017 18:20:31 -0400 [thread overview]
Message-ID: <a1163b4b-69b3-076c-b12c-4ff5a5356c0e@redhat.com> (raw)
In-Reply-To: <20170804213625.3756-1-ehabkost@redhat.com>
On 08/04/2017 05:36 PM, Eduardo Habkost wrote:
> This series adds the ability to run QMP commands
> non-interactively to qmp-shell, and deletes scripts/qmp/qmp.
>
> Eduardo Habkost (5):
> qmp-shell: Use argparse module
> qmp-shell: Pass split cmdargs to __build_cmd()
> qmp-shell: execute_cmdargs() method
> qmp-shell: Accept QMP command as argument
> Remove scripts/qmp/qmp
>
> scripts/qmp/qmp | 126 --------------------------------------------------
> scripts/qmp/qmp-shell | 90 ++++++++++++++++--------------------
> 2 files changed, 40 insertions(+), 176 deletions(-)
> delete mode 100755 scripts/qmp/qmp
>
Assuming there are no reasons to keep the old script around (I certainly
never used it) this appears to be fine. May as well fortify one really
good QMP tool instead of a dozen little half baked ones.
Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
prev parent reply other threads:[~2017-08-07 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 21:36 [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp Eduardo Habkost
2017-08-04 21:36 ` [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module Eduardo Habkost
2017-08-08 10:07 ` Stefan Hajnoczi
2017-08-08 10:11 ` Daniel P. Berrange
2017-08-08 12:57 ` Eduardo Habkost
2017-08-04 21:36 ` [Qemu-devel] [PATCH for-2.11 2/5] qmp-shell: Pass split cmdargs to __build_cmd() Eduardo Habkost
2017-08-08 10:09 ` Stefan Hajnoczi
2017-08-04 21:36 ` [Qemu-devel] [PATCH for-2.11 3/5] qmp-shell: execute_cmdargs() method Eduardo Habkost
2017-08-08 10:09 ` Stefan Hajnoczi
2017-08-04 21:36 ` [Qemu-devel] [PATCH for-2.11 4/5] qmp-shell: Accept QMP command as argument Eduardo Habkost
2017-08-08 10:11 ` Stefan Hajnoczi
2017-08-04 21:36 ` [Qemu-devel] [PATCH for-2.11 5/5] Remove scripts/qmp/qmp Eduardo Habkost
2017-08-08 10:11 ` Stefan Hajnoczi
2017-08-05 14:56 ` [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp Fam Zheng
2017-08-05 19:11 ` Eduardo Habkost
2017-08-07 2:26 ` Fam Zheng
2017-08-07 22:20 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1163b4b-69b3-076c-b12c-4ff5a5356c0e@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).