From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dongdong Zhang" <zhangdongdong@eswincomputing.com>,
qemu-devel@nongnu.org
Cc: jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH 1/1] Fix some typos
Date: Mon, 16 Jan 2023 19:10:14 +0100 [thread overview]
Message-ID: <a117f627-a043-4801-db65-114b0b0cc0a6@vivier.eu> (raw)
In-Reply-To: <d6fc6751-1fe2-78de-49f5-2a34554767af@linaro.org>
Le 30/11/2022 à 09:29, Philippe Mathieu-Daudé a écrit :
> On 30/11/22 02:53, Dongdong Zhang wrote:
>> Fix some typos in 'python' directory.
>>
>> Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> ---
>> python/qemu/machine/console_socket.py | 2 +-
>> python/qemu/machine/qtest.py | 2 +-
>> python/qemu/qmp/protocol.py | 2 +-
>> python/qemu/qmp/qmp_tui.py | 6 +++---
>> 4 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/python/qemu/machine/console_socket.py b/python/qemu/machine/console_socket.py
>> index 8c4ff598ad..4e28ba9bb2 100644
>> --- a/python/qemu/machine/console_socket.py
>> +++ b/python/qemu/machine/console_socket.py
>> @@ -68,7 +68,7 @@ def _thread_start(self) -> threading.Thread:
>> """Kick off a thread to drain the socket."""
>> # Configure socket to not block and timeout.
>> # This allows our drain thread to not block
>> - # on recieve and exit smoothly.
>> + # on receive and exit smoothly.
>> socket.socket.setblocking(self, False)
>> socket.socket.settimeout(self, 1)
>> drain_thread = threading.Thread(target=self._drain_fn)
>> diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
>> index 1a1fc6c9b0..906bd13298 100644
>> --- a/python/qemu/machine/qtest.py
>> +++ b/python/qemu/machine/qtest.py
>> @@ -42,7 +42,7 @@ class QEMUQtestProtocol:
>> :raise socket.error: on socket connection errors
>> .. note::
>> - No conection is estabalished by __init__(), this is done
>> + No connection is estabalished by __init__(), this is done
>> by the connect() or accept() methods.
>> """
>> def __init__(self, address: SocketAddrT,
>> diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py
>> index 6ea86650ad..15909b7dba 100644
>> --- a/python/qemu/qmp/protocol.py
>> +++ b/python/qemu/qmp/protocol.py
>> @@ -812,7 +812,7 @@ def _done(task: Optional['asyncio.Future[Any]']) -> bool:
>> @bottom_half
>> async def _bh_close_stream(self, error_pathway: bool = False) -> None:
>> - # NB: Closing the writer also implcitly closes the reader.
>> + # NB: Closing the writer also implicitly closes the reader.
>> if not self._writer:
>> return
>> diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py
>> index ce239d8979..8369144723 100644
>> --- a/python/qemu/qmp/qmp_tui.py
>> +++ b/python/qemu/qmp/qmp_tui.py
>> @@ -71,7 +71,7 @@ def format_json(msg: str) -> str:
>> due to an decoding error then a simple string manipulation is done to
>> achieve a single line JSON string.
>> - Converting into single line is more asthetically pleasing when looking
>> + Converting into single line is more aesthetically pleasing when looking
>> along with error messages.
>> Eg:
>> @@ -91,7 +91,7 @@ def format_json(msg: str) -> str:
>> [1, true, 3]: QMP message is not a JSON object.
>> - The single line mode is more asthetically pleasing.
>> + The single line mode is more aesthetically pleasing.
>> :param msg:
>> The message to formatted into single line.
>> @@ -498,7 +498,7 @@ def __init__(self, parent: App) -> None:
>> class HistoryBox(urwid.ListBox):
>> """
>> This widget is modelled using the ListBox widget, contains the list of
>> - all messages both QMP messages and log messsages to be shown in the TUI.
>> + all messages both QMP messages and log messages to be shown in the TUI.
>> The messages are urwid.Text widgets. On every append of a message, the
>> focus is shifted to the last appended message.
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
next prev parent reply other threads:[~2023-01-16 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 1:53 [PATCH 0/1] Fix some typos Dongdong Zhang
2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang
2022-11-30 8:29 ` Philippe Mathieu-Daudé
2023-01-16 18:10 ` Laurent Vivier [this message]
2023-01-16 20:06 ` John Snow
2023-01-05 23:57 ` Max Filippov
2022-12-16 3:22 ` [PING PATCH 0/1] " Dongdong Zhang
2023-01-05 23:25 ` John Snow
2023-01-06 1:50 ` Dongdong Zhang
2023-01-06 18:44 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a117f627-a043-4801-db65-114b0b0cc0a6@vivier.eu \
--to=laurent@vivier.eu \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhangdongdong@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).