From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Fabiano Rosas <farosas@linux.ibm.com>
Subject: Re: [RFC PATCH-for-8.0] target/arm: Keep "internals.h" internal to target/arm/
Date: Fri, 9 Dec 2022 17:05:55 +0100 [thread overview]
Message-ID: <a11c515a-49a0-c4a5-a0a5-e559170cf7f6@linaro.org> (raw)
In-Reply-To: <5f838c11-765b-72a3-0d40-5dd46994fd8e@linaro.org>
On 9/12/22 16:19, Richard Henderson wrote:
> On 12/9/22 05:17, Philippe Mathieu-Daudé wrote:
>> +++ b/target/arm/machine.c
>> @@ -6,6 +6,45 @@
>> #include "internals.h"
>> #include "migration/cpu.h"
>> +/* This mapping is common between ID_AA64MMFR0.PARANGE and
>> TCR_ELx.{I}PS. */
>> +static const uint8_t pamax_map[] = {
>> + [0] = 32,
>> + [1] = 36,
>> + [2] = 40,
>> + [3] = 42,
>> + [4] = 44,
>> + [5] = 48,
>> + [6] = 52,
>> +};
> ...
>> +++ b/target/arm/ptw.c
>> @@ -42,45 +42,6 @@ static bool get_phys_addr_with_struct(CPUARMState
>> *env, S1Translate *ptw,
>> ARMMMUFaultInfo *fi)
>> __attribute__((nonnull));
>> -/* This mapping is common between ID_AA64MMFR0.PARANGE and
>> TCR_ELx.{I}PS. */
>> -static const uint8_t pamax_map[] = {
>> - [0] = 32,
>> - [1] = 36,
>> - [2] = 40,
>> - [3] = 42,
>> - [4] = 44,
>> - [5] = 48,
>> - [6] = 52,
>> -};
>
> How does this even compile with the remaining usage of pamax_map in
> get_phys_addr_lpae?
It does not :( I rebased 62 patches then tried to extract/post unrelated
patches like this one, but didn't build at each step and failed to
realize the broken rebase, *sigh*. Sorry.
prev parent reply other threads:[~2022-12-09 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 11:17 [RFC PATCH-for-8.0] target/arm: Keep "internals.h" internal to target/arm/ Philippe Mathieu-Daudé
2022-12-09 11:26 ` Peter Maydell
2022-12-09 15:19 ` Richard Henderson
2022-12-09 16:05 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11c515a-49a0-c4a5-a0a5-e559170cf7f6@linaro.org \
--to=philmd@linaro.org \
--cc=farosas@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).