From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 1/3] linux-user: Fix fcntl() and fcntl64() to return O_LARGEFILE for 32-bit targets
Date: Sat, 8 Jul 2023 07:39:04 +0100 [thread overview]
Message-ID: <a128c6f3-1e29-4fee-f0ed-7e78b55a4b71@linaro.org> (raw)
In-Reply-To: <20230708054249.10245-2-deller@gmx.de>
On 7/8/23 06:42, Helge Deller wrote:
> When running a 32-bit guest on a 64-bit host, fcntl[64](F_GETFL) should
> return with the TARGET_O_LARGEFILE flag set, because all 64-bit hosts
> support large files unconditionally.
>
> But on 64-bit hosts, O_LARGEFILE has the value 0, so the flag
> translation can't be done with the fcntl_flags_tbl[]. Instead add the
> TARGET_O_LARGEFILE flag afterwards.
>
> Note that for 64-bit guests the compiler will optimize away this code,
> since TARGET_O_LARGEFILE is zero.
>
> Signed-off-by: Helge Deller<deller@gmx.de>
> ---
> linux-user/syscall.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-07-08 6:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 5:42 [PATCH v2 0/3] linux-user: Fix fcntl64() and accept4() for 32-bit targets Helge Deller
2023-07-08 5:42 ` [PATCH v2 1/3] linux-user: Fix fcntl() and fcntl64() to return O_LARGEFILE " Helge Deller
2023-07-08 6:39 ` Richard Henderson [this message]
2023-07-08 5:42 ` [PATCH v2 2/3] linux-user: Fix accept4(SOCK_NONBLOCK) syscall Helge Deller
2023-07-08 6:40 ` Richard Henderson
2023-07-09 18:03 ` Michael Tokarev
2023-07-08 5:42 ` [PATCH v2 3/3] linux-user: Improve strace output of pread64() and pwrite64() Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a128c6f3-1e29-4fee-f0ed-7e78b55a4b71@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).