Re: [PATCH 08/13] hw/xtensa/xtfpga: Replace memcpy()+tswap32() by stl_endian_p()

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 10/3/24 09:02, Philippe Mathieu-Daudé wrote:
> On 30/9/24 16:32, Thomas Huth wrote:
>> On 30/09/2024 09.34, Philippe Mathieu-Daudé wrote:
>>> Replace a pair of memcpy() + tswap32() by stl_endian_p(),
>>> which also swap the value using target endianness.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>    hw/xtensa/xtfpga.c | 6 ++----
>>>    1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c
>>> index 228f00b045..521fe84b01 100644
>>> --- a/hw/xtensa/xtfpga.c
>>> +++ b/hw/xtensa/xtfpga.c
>>> @@ -438,11 +438,9 @@ static void xtfpga_init(const XtfpgaBoardDesc
>>> *board, MachineState *machine)
>>>                const size_t boot_sz = TARGET_BIG_ENDIAN ? sizeof(boot_be)
>>>                                                         : sizeof(boot_le);
>>>                uint8_t *boot = TARGET_BIG_ENDIAN ? boot_be : boot_le;
>>> -            uint32_t entry_pc = tswap32(entry_point);
>>> -            uint32_t entry_a2 = tswap32(tagptr);
>>> -            memcpy(boot + 4, &entry_pc, sizeof(entry_pc));
>>> -            memcpy(boot + 8, &entry_a2, sizeof(entry_a2));
>>> +            stl_endian_p(TARGET_BIG_ENDIAN, boot + 4, entry_point);
>>> +            stl_endian_p(TARGET_BIG_ENDIAN, boot + 8, tagptr);
>>
>> Why don't you simply use stl_p() here?
> 
> We want to remove the tswap32() calls...
> 

I think is point is that you could directly use stl_be_p, instead of 
stl_endian_p(TARGET_BIT_ENDIAN, ...).
I don't know if your intent is to make be/le variant "private" and 
relies only on endian_p though.