From: David Hildenbrand <david@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com
Cc: stefanha@redhat.com, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] virtio-balloon: Fix page-poison subsection name
Date: Tue, 14 Sep 2021 15:51:04 +0200 [thread overview]
Message-ID: <a156ff43-a26e-3165-be6f-6d786fa8e773@redhat.com> (raw)
In-Reply-To: <32aacbf5-4693-9765-4d4d-410332669294@redhat.com>
On 14.09.21 15:47, Philippe Mathieu-Daudé wrote:
> On 9/14/21 3:17 PM, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> The subsection name for page-poison was typo'd as:
>>
>> vitio-balloon-device/page-poison
>>
>> Note the missing 'r' in virtio.
>>
>> When we have a machine type that enables page poison, and the guest
>> enables it (which needs a new kernel), things fail rather unpredictably.
>
> IIUC since v5.1 guests have 'page-poison'=true but once migrated
> they become 'page-poison'=unset=false?
We only migrate the subsection if the guest supports the feature (->
newer guest kernel).
If we migrate, it's a broken migration stream. If we don't migrate,
everything is fine.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-09-14 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 13:17 [PATCH] virtio-balloon: Fix page-poison subsection name Dr. David Alan Gilbert (git)
2021-09-14 13:21 ` David Hildenbrand
2021-09-14 13:30 ` Dr. David Alan Gilbert
2021-09-14 13:58 ` Daniel P. Berrangé
2021-09-14 14:16 ` Dr. David Alan Gilbert
2021-09-14 14:58 ` Philippe Mathieu-Daudé
2021-09-15 8:36 ` Dr. David Alan Gilbert
2021-09-14 13:47 ` Philippe Mathieu-Daudé
2021-09-14 13:51 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a156ff43-a26e-3165-be6f-6d786fa8e773@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).