From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH for-5.2? 2/2] Makefile: No echoing for 'make help V=1'
Date: Thu, 5 Nov 2020 17:35:12 +0100 [thread overview]
Message-ID: <a15bb85f-324a-542b-8048-39c5b9a6463d@redhat.com> (raw)
In-Reply-To: <160459122012.462591.8467906402712875729.stgit@bahia.lan>
On 05/11/20 16:47, Greg Kurz wrote:
> It doesn't bring much to have echoing with "make help". Suppress it
> unconditionally.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index df7a02a61a43..ba6b702107a5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -270,7 +270,7 @@ include $(SRC_PATH)/tests/docker/Makefile.include
> include $(SRC_PATH)/tests/vm/Makefile.include
>
> print-help-run = printf " %-30s - %s\\n" "$1" "$2"
> -print-help = $(quiet-@)$(call print-help-run,$1,$2)
> +print-help = @$(call print-help-run,$1,$2)
>
> .PHONY: help
> help:
>
>
Queued, thanks (the first was already in my tree).
Paolo
prev parent reply other threads:[~2020-11-05 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:46 [PATCH for-5.2? 1/2] Makefile: Don't use $(quiet-@) within the body of a recipe Greg Kurz
2020-11-05 15:47 ` [PATCH for-5.2? 2/2] Makefile: No echoing for 'make help V=1' Greg Kurz
2020-11-05 16:30 ` Philippe Mathieu-Daudé
2020-11-05 16:35 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15bb85f-324a-542b-8048-39c5b9a6463d@redhat.com \
--to=pbonzini@redhat.com \
--cc=groug@kaod.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).