From: Claudio Fontana <cfontana@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alex Bennee <alex.bennee@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: does make check now require TCG? Or is it a parallelism issue?
Date: Thu, 8 Oct 2020 23:07:03 +0200 [thread overview]
Message-ID: <a1694fe3-9bc8-df93-345f-29f0de37b923@suse.de> (raw)
In-Reply-To: <CABgObfYWK2E8PsSFOcHpuA2vuA3HWgvtuLbrtQCWA=9=r07=5w@mail.gmail.com>
On 10/8/20 8:24 PM, Paolo Bonzini wrote:
>
>
> Il gio 8 ott 2020, 20:05 Richard Henderson <richard.henderson@linaro.org <mailto:richard.henderson@linaro.org>> ha scritto:
>
> Ah, TARGET_DIRS isn't being pruned anymore when a target is disabled for lack
> of accelerator.
>
> Paolo, side effect of 8a19980e3f ("configure: move accelerator logic to
> meson")? I guess we should move the setting of TARGET_DIRS to meson as well.
>
>
> TARGET_DIRS is pruned by Meson, I didn't add any back propagation to make because it is not really needed; qemu-iotests only every uses the "host architecture" QEMU binary (see tests/qemu-iotests/common.config), check-block + --target-list has never worked.
>
> check-tcg could use the pruned TARGET_DIRS, but it is of limited use anyway with --disable-tcg.
>
> At this point it may make sense to establish which config-host.mak variables are available in the Makefile, because there's probably just a handful. I won't have much time in the next couple of weeks though.
>
> Paolo
>
>
> r~
>
qtests are also broken for me now with --disable-tcg build,
it _seems_ to me that TCG-only tests are being run for --disable-tcg too.
I am not sure if this is a test problem (for example tests/qtest/bios-tables-test.c): data->tcg_only
or if it is a build system problem, or some combination.
make check-qtest
...
Running test qtest-x86_64: device-plug-test
Running test qtest-x86_64: drive_del-test
Running test qtest-x86_64: tco-test
Running test qtest-x86_64: cpu-plug-test
Running test qtest-x86_64: q35-test
Running test qtest-x86_64: vmgenid-test
Running test qtest-x86_64: migration-test
Running test qtest-x86_64: test-x86-cpuid-compat
Running test qtest-x86_64: numa-test
Running test qtest-x86_64: cdrom-test
Running test qtest-x86_64: device-introspect-test
Running test qtest-x86_64: machine-none-test
Running test qtest-x86_64: qmp-test
Running test qtest-x86_64: qmp-cmd-test
Running test qtest-x86_64: qom-test
Running test qtest-x86_64: test-hmp
Running test qtest-x86_64: qos-test
qemu-system-x86_64: -accel tcg: invalid accelerator tcg
qemu-system-x86_64: falling back to QTest
ERROR:../tests/qtest/boot-sector.c:161:boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
ERROR qtest-x86_64: bios-tables-test - too few tests run (expected 23, got 22)
make: *** [Makefile.mtest:1298: run-test-183] Error 1
make: *** Waiting for unfinished jobs....
next prev parent reply other threads:[~2020-10-08 21:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:48 does make check now require TCG? Or is it a parallelism issue? Claudio Fontana
2020-10-08 15:02 ` Paolo Bonzini
2020-10-08 15:34 ` Claudio Fontana
2020-10-08 16:25 ` Claudio Fontana
2020-10-08 16:31 ` Paolo Bonzini
2020-10-08 16:35 ` Claudio Fontana
2020-10-08 16:51 ` Claudio Fontana
2020-10-09 9:23 ` Philippe Mathieu-Daudé
2020-10-09 9:40 ` Claudio Fontana
2020-10-09 10:35 ` Pavel Dovgalyuk
2020-10-09 11:46 ` Paolo Bonzini
2020-10-08 17:44 ` Richard Henderson
2020-10-08 17:53 ` Claudio Fontana
2020-10-08 18:05 ` Richard Henderson
2020-10-08 18:24 ` Paolo Bonzini
2020-10-08 21:07 ` Claudio Fontana [this message]
2020-10-09 7:40 ` Paolo Bonzini
2020-10-09 10:28 ` Claudio Fontana
2020-10-09 11:49 ` Paolo Bonzini
2020-10-09 12:13 ` Peter Maydell
2020-10-09 13:32 ` Claudio Fontana
2020-10-09 17:10 ` Paolo Bonzini
2020-10-09 7:21 ` Thomas Huth
2020-10-09 7:37 ` Paolo Bonzini
2020-10-09 9:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1694fe3-9bc8-df93-345f-29f0de37b923@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).