From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4C88C433EF for ; Sat, 16 Apr 2022 02:52:30 +0000 (UTC) Received: from localhost ([::1]:52028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfYY1-0005Wa-RW for qemu-devel@archiver.kernel.org; Fri, 15 Apr 2022 22:52:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfYW8-0003jK-FQ for qemu-devel@nongnu.org; Fri, 15 Apr 2022 22:50:36 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:42991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfYW5-0003M2-Cc for qemu-devel@nongnu.org; Fri, 15 Apr 2022 22:50:31 -0400 Received: by mail-pg1-x534.google.com with SMTP id bg9so9380600pgb.9 for ; Fri, 15 Apr 2022 19:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=b4bguhTjW+b5Asu527rfuN6CfaRQdYkMKK8zSVOczqs=; b=zMYmI4wDaatRAEVqxc7zSkZ/+0j1D4J5U4E2IMY4TCTnwVTku2z0rXuBN+94QWzbQC fWAbQuGq82JhwzsqXO6rTckXsNy3wGknl2TqyUTnSdJFvsUbprRw43xiZlj4htzq7ZDv j7GGeblwthzh+t9q+WHEd4GlxtlDoD7olSvicoe+nYjvj/NjGw/PVEC47b13ngSFOSa3 fKmV8AqlRWrIAqbNiBSZ5micisC7I5Zz6IZQ6t0BCXYgr15BcYGONDPVxBZmcGHGqKbQ HupOcx5RRGl2fW06RYmtR5bqxGu6nXWVH7v300mPnarM3Z3W9jr/ye/nms/qUCMQnsO/ DmSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=b4bguhTjW+b5Asu527rfuN6CfaRQdYkMKK8zSVOczqs=; b=DyU61azwzxspvE6b77zWWGmXkndYgDzih5ECvt0cIYh4IjtfqP+0EdoAZUYbcIkYn4 tVnKOktotga7ftM2ZTF//rAIpwQgnqtLxJ6/mwk5Z9RH3Ziwbmn0OHSWrSWNUI01YnkA BAKnPaSSAMN5wFaKkGA/aYNUR3WVE73z4eXOwX7R9NyUyjRseY6/uqZPVfisQCcn9s+a jTlHB/+kNAkR6XseN0BX0OZvS7I1RAMEVubWcV9JWpcCh+Dgucn92j9neCh3QyWGsyKf NCT1psFsEGTsXeorlQp8t9LU5Q/yeb3PYavk6UKnInt41dts8LI40sbfzXohpunDeVC8 TTRQ== X-Gm-Message-State: AOAM533yiqT3UeW5TX/SQFTtabKLSekBvwm4l0pDQCu1t4/Mq/b+5h4H RslGSmtYvZjtPFqLDsrRFy7+jw== X-Google-Smtp-Source: ABdhPJyEx5tW372KYt/ihZbUjFALT7h/391+v5PwHpk+AMQuEheVkaGqcGr0SKjjJLBWyLDFm0bQlw== X-Received: by 2002:a63:931e:0:b0:39d:9d36:545d with SMTP id b30-20020a63931e000000b0039d9d36545dmr1422273pge.511.1650077427951; Fri, 15 Apr 2022 19:50:27 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id l25-20020a635719000000b0039da6cdf82dsm5619278pgb.83.2022.04.15.19.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 19:50:27 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 19:50:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v10 06/14] target/riscv: rvk: add support for zknd/zkne extension in RV32 Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20220416023549.28463-1-liweiwei@iscas.ac.cn> <20220416023549.28463-7-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20220416023549.28463-7-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, luruibo2000@163.com, lustrew@foxmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/15/22 19:35, Weiwei Li wrote: > +target_ulong HELPER(aes32esmi)(target_ulong rs1, target_ulong rs2, > + target_ulong shamt) > +{ > + return aes32_operation(shamt, rs1, rs2, true, true); > +} > + > +target_ulong HELPER(aes32esi)(target_ulong rs1, target_ulong rs2, > + target_ulong shamt) > +{ > + return aes32_operation(shamt, rs1, rs2, true, false); > +} > + > +target_ulong HELPER(aes32dsmi)(target_ulong rs1, target_ulong rs2, > + target_ulong shamt) > +{ > + return aes32_operation(shamt, rs1, rs2, false, true); > +} > + > +target_ulong HELPER(aes32dsi)(target_ulong rs1, target_ulong rs2, > + target_ulong shamt) > +{ > + return aes32_operation(shamt, rs1, rs2, false, false); > +} Missing REQUIRE_32BIT tests. r~