From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
To: "its@irrelevant.dk" <its@irrelevant.dk>
Cc: "hreitz@redhat.com" <hreitz@redhat.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"philmd@linaro.org" <philmd@linaro.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"foss@defmacro.it" <foss@defmacro.it>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"marcel.apfelbaum@gmail.com" <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH v6 5/5] hw/nvme: connect SPDM over NVMe Security Send/Recv
Date: Fri, 12 Sep 2025 02:13:36 +0000 [thread overview]
Message-ID: <a16e627152815e95e6795ea5e685c2042910fadc.camel@wdc.com> (raw)
In-Reply-To: <aMJsjobzyBEuny43@AALNPWKJENSEN.aal.scsc.local>
On Thu, 2025-09-11 at 08:30 +0200, Klaus Jensen wrote:
> On Sep 11 16:00, Wilfred Mallawa wrote:
> > From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> >
> > This patch extends the existing support we have for NVMe with only
> > DoE
> > to also add support to SPDM over the NVMe Security Send/Recv
> > commands.
> >
> > With the new definition of the `spdm-trans` argument, users can
> > specify
> > `spdm_trans=nvme` or `spdm_trans=doe`. This allows us to select the
> > SPDM
> > transport respectively. SPDM over the NVMe Security Send/Recv
> > commands
> > are defined in the DMTF DSP0286.
> >
> > Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> LGTM. One small nit below that I can fix when merging if another
> revision is not rolled.
Hey Klaus,
I've sent a V7 with this addressed. Thanks for the feedback!
Regards,
Wilfred
[...]
prev parent reply other threads:[~2025-09-12 2:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 6:00 [PATCH v6 0/5] NVMe: Add SPDM over the storage transport support Wilfred Mallawa
2025-09-11 6:00 ` [PATCH v6 1/5] spdm-socket: add seperate send/recv functions Wilfred Mallawa
2025-09-11 6:00 ` [PATCH v6 2/5] spdm: add spdm storage transport virtual header Wilfred Mallawa
2025-09-11 6:00 ` [PATCH v6 3/5] hw/nvme: add NVMe Admin Security SPDM support Wilfred Mallawa
2025-09-11 6:24 ` Klaus Jensen
2025-09-11 6:00 ` [PATCH v6 4/5] spdm: define SPDM transport enum types Wilfred Mallawa
2025-09-11 6:00 ` [PATCH v6 5/5] hw/nvme: connect SPDM over NVMe Security Send/Recv Wilfred Mallawa
2025-09-11 6:30 ` Klaus Jensen
2025-09-12 2:13 ` Wilfred Mallawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16e627152815e95e6795ea5e685c2042910fadc.camel@wdc.com \
--to=wilfred.mallawa@wdc.com \
--cc=Alistair.Francis@wdc.com \
--cc=fam@euphon.net \
--cc=foss@defmacro.it \
--cc=hreitz@redhat.com \
--cc=its@irrelevant.dk \
--cc=jonathan.cameron@huawei.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).