From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73C87CCA476 for ; Mon, 13 Oct 2025 09:22:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8Ek5-0001dF-LV; Mon, 13 Oct 2025 05:21:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8Ek0-0001Vz-0I for qemu-devel@nongnu.org; Mon, 13 Oct 2025 05:21:17 -0400 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8Ejp-0004G3-Lv for qemu-devel@nongnu.org; Mon, 13 Oct 2025 05:21:15 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.110.43.14]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 4clWzx67c3z5wnV; Mon, 13 Oct 2025 09:21:01 +0000 (UTC) Received: from kaod.org (37.59.142.101) by DAG8EX2.mxp5.local (172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.59; Mon, 13 Oct 2025 11:21:01 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G0043a42d21c-91ba-48a1-8b0a-e37a13fb74ab, E27D2F41E47E806E38994DC6761E007B2CBA9264) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Mon, 13 Oct 2025 11:21:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [SPAM] [PATCH v3 03/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_soc_uart_set_chr() API To: Jamin Lin , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , References: <20251013054334.955331-1-jamin_lin@aspeedtech.com> <20251013054334.955331-4-jamin_lin@aspeedtech.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20251013054334.955331-4-jamin_lin@aspeedtech.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG8EX2.mxp5.local (172.16.2.72) To DAG8EX2.mxp5.local (172.16.2.72) X-Ovh-Tracer-GUID: bd4d8d9c-ae76-4d05-ace2-98b1f93749ff X-Ovh-Tracer-Id: 14158472807252593586 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTGNoIoHsu1xdOBH/Eke09bYtRVh1g27RjmeSMpnyv7nAK+F8allf1PWKYPOYsduizeaEsMA6hQJ/T/nDXMg0wVwFuul5lcaezk9p7GzLXTZtSXacMQGO4hi34Pa/Ga+g3b+XlozH/D8Jm3oSIi82DQ9MRC1SBNc4jrwnfwe91gdxYI/tSQyoM3YLYRZLPxE8+PGho4xkEEjTvEQljQqaddf+ObOCX/UIiOY795rxVHyVgi5OR3lUZQREr2FMaY8x7ICdtRsoIKqNFT0NK4jJyQUZ8wIY0j6m7Lo/d/UmPVE993/fnI5bl8QiOrvfYVrJBUsOI21xH+eHsrUsc4O4WXaBzrKUu87m5Lz53AinoT+2WUkfbYKBlV9OdqJjpCPSs2EKKsrOc3qXmLVAvbsxZ/x8e0OEbPGdHCfGcN9zhhw6s9XK4wIwPrlFElj/HsdmWbAyHsXamHjeh1AHVxx9gwYtJo+v32KFUP5jkuJcLH2dBAhStNFoap/ztbTYarKT+ab8RHMGvOGUb4SfqoL5fivaL9dzwBVgFztdSdcVCo2LGFdW8vjMCHtVsgK7Sm+DgSxpJ3hXzmyh4bpbhH/CezJfcPfukPaRitrXggt40A+EdrSadUoaHaaFvHU7B/+JbHSH+fLJUC0INcoUGzNjILJVTEatW2PHkgvg53tO4kFZg DKIM-Signature: a=rsa-sha256; bh=mzKP+EiXwQalivGj5k+5h0T/uQkBrQ0n8YX3yKr5y38=; c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1; t=1760347262; v=1; b=CSAa5AyPNP+hhRde26BHddRTfYEm3zGyWqXlw8UlenfdSfbacelGwQWY5iC9Ldib1lSp4cfK YukQ3IdsZJelTSHuxh3dyEqk0pmcrDkRPa8sEHLEMUm1X2RKu90xpcLCqlRzJKCC2DjhABOngWT e0jEnsEmElOh5cWIvVLE5eE125aEj/0H6rq82yAQ694sLmPPupb3qAGCU/RSbparY4xSZK8c76j ibM0nzOuwqgpmXXPmnCcwz+fJTwxVQY8YvTI09lrxUpoFEOWa/7AJ8csTykb5q2/owq8DnlHgA4 nPx9xO5vwQvFgpSQuKF6r7K7KRwjUvqFkG/yuy5uu1T8w== Received-SPF: pass client-ip=178.32.125.2; envelope-from=clg@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/13/25 07:43, Jamin Lin wrote: > Refactor the aspeed_soc_uart_set_chr() helper to remove its dependency > on AspeedSoCState and make the UART character device binding more > generic. > > The function now takes SerialMM *uart, uarts_base, and uarts_num > as arguments instead of relying on AspeedSoCState. All affected call > sites in aspeed.c, aspeed_ast27x0-fc.c, and fby35.c are updated > to use the new parameter format. > > This improves API flexibility and enables reuse across different Aspeed > SoC variants without requiring access to internal SoC state. > > No functional change. > > Signed-off-by: Jamin Lin > --- > include/hw/arm/aspeed_soc.h | 3 ++- > hw/arm/aspeed.c | 6 ++++-- > hw/arm/aspeed_ast27x0-fc.c | 13 ++++++++++--- > hw/arm/aspeed_soc_common.c | 10 +++++----- > hw/arm/fby35.c | 10 ++++++++-- > 5 files changed, 29 insertions(+), 13 deletions(-) > Reviewed-by: Cédric Le Goater Thanks, C.