From: Jagannathan Raman <jag.raman@oracle.com>
To: qemu-devel@nongnu.org
Cc: elena.ufimtseva@oracle.com, fam@euphon.net,
swapnil.ingle@nutanix.com, john.g.johnson@oracle.com,
kraxel@redhat.com, jag.raman@oracle.com, quintela@redhat.com,
mst@redhat.com, armbru@redhat.com, kanth.ghatraju@oracle.com,
felipe@nutanix.com, thuth@redhat.com, ehabkost@redhat.com,
konrad.wilk@oracle.com, dgilbert@redhat.com,
alex.williamson@redhat.com, stefanha@redhat.com,
thanos.makatos@nutanix.com, kwolf@redhat.com,
berrange@redhat.com, mreitz@redhat.com,
ross.lagerwall@citrix.com, marcandre.lureau@gmail.com,
pbonzini@redhat.com
Subject: [PATCH v20 07/20] io: add qio_channel_writev_full_all helper
Date: Tue, 19 Jan 2021 15:28:24 -0500 [thread overview]
Message-ID: <a18dca8276a637abf672282fa79f05a8e6136236.1611081587.git.jag.raman@oracle.com> (raw)
In-Reply-To: <cover.1611081587.git.jag.raman@oracle.com>
From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Adds qio_channel_writev_full_all() to transmit both data and FDs.
Refactors existing code to use this helper.
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
---
include/io/channel.h | 25 +++++++++++++++++++++++++
io/channel.c | 15 ++++++++++++++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/include/io/channel.h b/include/io/channel.h
index ab9ea77..19e76fc 100644
--- a/include/io/channel.h
+++ b/include/io/channel.h
@@ -777,4 +777,29 @@ void qio_channel_set_aio_fd_handler(QIOChannel *ioc,
IOHandler *io_write,
void *opaque);
+/**
+ * qio_channel_writev_full_all:
+ * @ioc: the channel object
+ * @iov: the array of memory regions to write data from
+ * @niov: the length of the @iov array
+ * @fds: an array of file handles to send
+ * @nfds: number of file handles in @fds
+ * @errp: pointer to a NULL-initialized error object
+ *
+ *
+ * Behaves like qio_channel_writev_full but will attempt
+ * to send all data passed (file handles and memory regions).
+ * The function will wait for all requested data
+ * to be written, yielding from the current coroutine
+ * if required.
+ *
+ * Returns: 0 if all bytes were written, or -1 on error
+ */
+
+int qio_channel_writev_full_all(QIOChannel *ioc,
+ const struct iovec *iov,
+ size_t niov,
+ int *fds, size_t nfds,
+ Error **errp);
+
#endif /* QIO_CHANNEL_H */
diff --git a/io/channel.c b/io/channel.c
index 93d449d..0d4b8b5 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -157,6 +157,15 @@ int qio_channel_writev_all(QIOChannel *ioc,
size_t niov,
Error **errp)
{
+ return qio_channel_writev_full_all(ioc, iov, niov, NULL, 0, errp);
+}
+
+int qio_channel_writev_full_all(QIOChannel *ioc,
+ const struct iovec *iov,
+ size_t niov,
+ int *fds, size_t nfds,
+ Error **errp)
+{
int ret = -1;
struct iovec *local_iov = g_new(struct iovec, niov);
struct iovec *local_iov_head = local_iov;
@@ -168,7 +177,8 @@ int qio_channel_writev_all(QIOChannel *ioc,
while (nlocal_iov > 0) {
ssize_t len;
- len = qio_channel_writev(ioc, local_iov, nlocal_iov, errp);
+ len = qio_channel_writev_full(ioc, local_iov, nlocal_iov, fds, nfds,
+ errp);
if (len == QIO_CHANNEL_ERR_BLOCK) {
if (qemu_in_coroutine()) {
qio_channel_yield(ioc, G_IO_OUT);
@@ -182,6 +192,9 @@ int qio_channel_writev_all(QIOChannel *ioc,
}
iov_discard_front(&local_iov, &nlocal_iov, len);
+
+ fds = NULL;
+ nfds = 0;
}
ret = 0;
--
1.8.3.1
next prev parent reply other threads:[~2021-01-19 21:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 20:28 [PATCH v20 00/20] Initial support for multi-process Qemu Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 01/20] multi-process: add the concept description to docs/devel/qemu-multiprocess Jagannathan Raman
2021-01-25 16:57 ` Cédric Le Goater
2021-01-27 16:47 ` Jag Raman
2021-01-28 9:53 ` Thanos Makatos
2021-01-19 20:28 ` [PATCH v20 02/20] multi-process: add configure and usage information Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 03/20] memory: alloc RAM from file at offset Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 04/20] multi-process: Add config option for multi-process QEMU Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 05/20] multi-process: setup PCI host bridge for remote device Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 06/20] multi-process: setup a machine object for remote device process Jagannathan Raman
2021-01-19 20:28 ` Jagannathan Raman [this message]
2021-01-19 20:28 ` [PATCH v20 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers Jagannathan Raman
2021-01-25 16:41 ` Daniel P. Berrangé
2021-01-19 20:28 ` [PATCH v20 09/20] multi-process: define MPQemuMsg format and transmission functions Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 10/20] multi-process: Initialize message handler in remote device Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 11/20] multi-process: Associate fd of a PCIDevice with its object Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 12/20] multi-process: setup memory manager for remote device Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 13/20] multi-process: introduce proxy object Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 14/20] multi-process: add proxy communication functions Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 15/20] multi-process: Forward PCI config space acceses to the remote process Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 16/20] multi-process: PCI BAR read/write handling for proxy & remote endpoints Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 17/20] multi-process: Synchronize remote memory Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 18/20] multi-process: create IOHUB object to handle irq Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 19/20] multi-process: Retrieve PCI info from remote process Jagannathan Raman
2021-01-19 20:28 ` [PATCH v20 20/20] multi-process: perform device reset in the " Jagannathan Raman
2021-01-21 17:07 ` [PATCH v20 00/20] Initial support for multi-process Qemu Stefan Hajnoczi
2021-01-21 17:37 ` Jag Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18dca8276a637abf672282fa79f05a8e6136236.1611081587.git.jag.raman@oracle.com \
--to=jag.raman@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=felipe@nutanix.com \
--cc=john.g.johnson@oracle.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ross.lagerwall@citrix.com \
--cc=stefanha@redhat.com \
--cc=swapnil.ingle@nutanix.com \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).