Re: [PATCH v2 2/2] gitlab-ci: Add a job to build virtiofsd standalone

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/29/21 3:16 PM, Wainer dos Santos Moschetta wrote:
> Hi,
> 
> On 4/29/21 5:33 AM, Philippe Mathieu-Daudé wrote:
>> Add a job which builds virtiofsd without any emulation or tool.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> https://gitlab.com/philmd/qemu/-/jobs/1222007991
>> Duration: 7 minutes 48 seconds
>> ---
>>   .gitlab-ci.yml | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 52d65d6c04f..ba3c7ade6ca 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -800,6 +800,19 @@ build-libvhost-user:
>>       - meson
>>       - ninja
>>   +build-virtiofsd-fedora:
>> +  <<: *native_build_job_definition
>> +  needs:
>> +    job: amd64-fedora-container
>> +  variables:
>> +    IMAGE: fedora
>> +    CONFIGURE_ARGS: --enable-virtiofsd
>> +        --disable-system --disable-user --disable-tools --disable-docs
>> +  artifacts:
>> +    expire_in: 2 days
>> +    paths:
>> +      - build/tools/virtiofsd/virtiofsd
>> +
> 
> Why it needs the executable archived?

I assumed if there were testing jobs as next stage, this is what they
would consume? I copy/pasted from another job and adapted, but you are
right, it is pointless. AnyhowI understood this job has been discarded
during review.

Thanks for having a look!

Phil.