From: Paolo Bonzini <pbonzini@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: eesposit@redhat.com, kwolf@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command
Date: Tue, 23 Mar 2021 22:20:46 +0100 [thread overview]
Message-ID: <a19c681e-94ee-f69d-53b0-14239bdc5d01@redhat.com> (raw)
In-Reply-To: <5ba856d3-8325-dc28-4806-7f5cce4d5522@virtuozzo.com>
On 23/03/21 20:12, Vladimir Sementsov-Ogievskiy wrote:
>>
>>
>> Move the trailing empty line to print_env(), since it always looks better
>> and one caller was not adding it.
>
> Seems you've moved this fix from one unrelated commit to another.. And
> it touches two extra files. I'd just make it a separate commit.
> Nitpicking. Separate or as is:
Well, now I add the third caller so it's time to make up our mind on the
trailing line. A two-line commit didn't seem worth it.
Paolo
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
next prev parent reply other threads:[~2021-03-23 21:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 18:19 [PATCH v2 0/5] qemu-iotests: quality of life improvements Paolo Bonzini
2021-03-23 18:19 ` [PATCH v2 1/5] qemu-iotests: do not buffer the test output Paolo Bonzini
2021-03-23 18:54 ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:57 ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:19 ` [PATCH v2 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts Paolo Bonzini
2021-03-23 19:02 ` Vladimir Sementsov-Ogievskiy
2021-03-23 19:17 ` Vladimir Sementsov-Ogievskiy
2021-03-23 21:22 ` Paolo Bonzini
2021-03-24 7:34 ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:19 ` [PATCH v2 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv Paolo Bonzini
2021-03-23 18:19 ` [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command Paolo Bonzini
2021-03-23 19:12 ` Vladimir Sementsov-Ogievskiy
2021-03-23 21:20 ` Paolo Bonzini [this message]
2021-03-24 7:36 ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:19 ` [PATCH v2 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment Paolo Bonzini
2021-03-24 15:17 ` [PATCH v2 0/5] qemu-iotests: quality of life improvements Emanuele Giuseppe Esposito
2021-03-25 18:15 ` Max Reitz
2021-03-26 6:50 ` Paolo Bonzini
2021-03-26 13:40 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19c681e-94ee-f69d-53b0-14239bdc5d01@redhat.com \
--to=pbonzini@redhat.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).