qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
	qemu-devel@nongnu.org, Chrysostomos Nanakos <chris@include.gr>,
	Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile
Date: Wed, 8 Mar 2017 19:27:19 +0100	[thread overview]
Message-ID: <a1ba003c-9737-4d3d-a495-c8267f11beb2@redhat.com> (raw)
In-Reply-To: <e7e616d7-441f-9cff-d182-cbda19700ec5@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On 08.03.2017 19:25, Eric Blake wrote:
> On 03/08/2017 12:18 PM, Max Reitz wrote:
>> In order to use error_setg() and similar functions, we need to include
>> qapi/error.h.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  block/archipelago.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Does this mean our automated buildbots aren't building archipelago by
> default?

Well, at least patchew didn't catch that I definitely broke archipelago
in my bdrv_truncate() errp series...

[CC-ing Fam]

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

  reply	other threads:[~2017-03-08 18:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 18:18 [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile Max Reitz
2017-03-08 18:25 ` Eric Blake
2017-03-08 18:27   ` Max Reitz [this message]
2017-03-08 18:28   ` Eric Blake
2017-03-08 18:32     ` Max Reitz
2017-03-08 18:46       ` Kevin Wolf
2017-03-08 19:33         ` Eric Blake
2017-03-08 18:38   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1ba003c-9737-4d3d-a495-c8267f11beb2@redhat.com \
    --to=mreitz@redhat.com \
    --cc=chris@include.gr \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).