Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

[Thomas Huth <thuth@redhat.com>]

On 10/01/2022 10.35, Philippe Mathieu-Daudé wrote:
> Hi Patrick,
> 
> On 1/8/22 04:04, Patrick Venture wrote:
>> From: Hao Wu <wuhaotsh@google.com>
>>
>> SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible
>> interface that reports AMD SoC's Ttcl (normalized temperature),
>> and resembles a typical 8-pin remote temperature sensor's I2C interface
>> to BMC.
>>
>> This patch implements a basic AMD SB-TSI sensor that is
>> compatible with the open-source data sheet from AMD and Linux
>> kernel driver.
>>
>> Reference:
>> Linux kernel driver:
>> https://lkml.org/lkml/2020/12/11/968
>> Register Map:
>> https://developer.amd.com/wp-content/resources/56255_3_03.PDF
>> (Chapter 6)
>>
>> Signed-off-by: Hao Wu <wuhaotsh@google.com>
>> Reviewed-by: Doug Evans <dje@google.com>
>> ---
>>   hw/sensor/Kconfig            |   4 +
>>   hw/sensor/meson.build        |   1 +
>>   hw/sensor/tmp_sbtsi.c        | 393 +++++++++++++++++++++++++++++++++++
>>   hw/sensor/trace-events       |   5 +
>>   hw/sensor/trace.h            |   1 +
>>   meson.build                  |   1 +
> 
>>   tests/qtest/meson.build      |   1 +
>>   tests/qtest/tmp_sbtsi-test.c | 180 ++++++++++++++++
> 
> Up to Thomas for qtest, but I'd rather split in 2 patches since
> different set of maintainers / reviewers.

I don't mind too much - but anyway, I'd prefer if we could stick to "-" in 
file names here - mixing underscores and "-" in file names looks somewhat 
weird (I know, there are already some files like this, but I'd prefer if 
we'd not extend that list).

  Thomas