From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btaRU-00011o-92 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btaRQ-0002tD-1R for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:16:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:62833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btaRP-0002fW-Rm for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:16:27 -0400 References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-4-git-send-email-guangrong.xiao@linux.intel.com> <20160930151422.6327c7d1@nial.brq.redhat.com> <88933673-0afc-7389-f792-43bd7f6a1bcc@linux.intel.com> <20161010145113.71229994@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: Date: Mon, 10 Oct 2016 21:09:30 +0800 MIME-Version: 1.0 In-Reply-To: <20161010145113.71229994@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/10/2016 08:51 PM, Igor Mammedov wrote: > On Sat, 8 Oct 2016 15:17:14 +0800 > Xiao Guangrong wrote: > >> On 09/30/2016 09:14 PM, Igor Mammedov wrote: >>> On Fri, 12 Aug 2016 14:54:05 +0800 >>> Xiao Guangrong wrote: >>> >>>> _FIT is required for hotplug support, guest will inquire the updated >>>> device info from it if a hotplug event is received >>>> >>>> As FIT buffer is not completely mapped into guest address space, so a >>>> new function, Read FIT whose function index is 0xFFFFFFFF, is reserved >>>> by QEMU to read the piece of FIT buffer. The buffer is concatenated >>>> before _FIT return >>> Only issuer of UUID 2F10E7A4-9E91-11E4-89D3-123B93F75CBA can reserve >>> 0xFFFFFFFF for some purposes. >>> So spec should be amended first or custom generated UUID should be used. >> >> Okay. >> >> I will change the changelog to reflect this fact and move the spec update >> to this patch. > under spec, I've meant ACPI spec where this UUID is declared Er. ACPI spec just said that "0xFFFF is reserved", not sure it will be used in the future. I'd prefer to custom-generated UUID, however, currently the UUID is checked in OSPM, i.e, QEMU is not able to distinguish other UUIDs, so how about drop the UUID check in ACPI and pass the UUID info to QEMU?