From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org
Cc: "Jason J. Herne" <jjherne@linux.ibm.com>,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
David Hildenbrand <david@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH] target/s390x: Remove non-architected entries from struct LowCore
Date: Tue, 5 Mar 2019 08:12:55 +0100 [thread overview]
Message-ID: <a1d91dfd-a6dc-d06c-332c-1865cbc3c08a@redhat.com> (raw)
In-Reply-To: <1551769785-17717-1-git-send-email-thuth@redhat.com>
On 05/03/2019 08.09, Thomas Huth wrote:
> There are some fields in our struct LowCore which apparently have
> been copied from a very old version of the Linux kernel. These
> fields are not architected in the "Principles of Operation", and
> only used on these memory locations in Linux kernels older than
> 2.6.29. Newer Linux kernels moved the entries to different locations
> or are not using them at all anymore. Thus we should never access
> these fields from the QEMU side, so they should be removed.
>
> While we're at it, also add a QEMU_BUILD_BUG_MSG() statement to
> assert that struct LowCore has the right size.
Uh, sorry, wrong version of the patch, please ignore, I did not add the
QEMU_BUILD_BUG_MSG() here yet. I'll send a v2 in a minute...
Thomas
prev parent reply other threads:[~2019-03-05 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 7:09 [Qemu-devel] [PATCH] target/s390x: Remove non-architected entries from struct LowCore Thomas Huth
2019-03-05 7:12 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d91dfd-a6dc-d06c-332c-1865cbc3c08a@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).