From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Jason Wang" <jasowang@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
qemu-arm@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org
Subject: Re: [RFC PATCH-for-8.0 1/3] hw/ppc: Replace tswap32() by const_le32()
Date: Tue, 13 Dec 2022 10:14:01 -0600 [thread overview]
Message-ID: <a1f4b5a6-0a8a-5a04-8ab6-f3f08b9d36aa@linaro.org> (raw)
In-Reply-To: <d73fe725-565e-7fcb-e7d3-846189459545@linaro.org>
On 12/13/22 10:10, Philippe Mathieu-Daudé wrote:
> On 13/12/22 17:00, Richard Henderson wrote:
>> On 12/13/22 06:52, Philippe Mathieu-Daudé wrote:
>>> Assuming the developers of commits 2c50e26efd ("powerpc: Add
>>> a virtex5 ml507 refdesign board") and 4b387f9ee1 ("ppc: Add
>>> aCube Sam460ex board") were testing on a little-endian setup,
>>> they meant to use const_le32() instead of tswap32() here,
>>> since tswap32() depends on the host endianness.
>>
>> tswap depends on target endianness.
>
> Yes, it depends on both host/target endianness. What I meant
> is we shouldn't have system code depending on host endianness.
It compares host vs target endianness, to determine if a swap is needed. But the real
dependency is target endianness.
r~
next prev parent reply other threads:[~2022-12-13 16:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 12:52 [RFC PATCH-for-8.0 0/3] hw/ppc: Remove tswap() calls Philippe Mathieu-Daudé
2022-12-13 12:52 ` [RFC PATCH-for-8.0 1/3] hw/ppc: Replace tswap32() by const_le32() Philippe Mathieu-Daudé
2022-12-13 16:00 ` Richard Henderson
2022-12-13 16:10 ` Philippe Mathieu-Daudé
2022-12-13 16:14 ` Richard Henderson [this message]
2022-12-13 16:21 ` Peter Maydell
2022-12-13 16:27 ` Richard Henderson
2022-12-13 16:53 ` Cédric Le Goater
2022-12-13 17:23 ` Peter Maydell
2022-12-13 17:51 ` Edgar E. Iglesias
2022-12-13 18:09 ` BALATON Zoltan
2022-12-13 21:37 ` Peter Maydell
2022-12-13 18:13 ` Cédric Le Goater
2023-05-17 10:51 ` Thomas Huth
2022-12-13 12:52 ` [RFC PATCH-for-8.0 2/3] hw/ppc/spapr: Replace tswap64(HPTE) by cpu_to_be64(HPTE) Philippe Mathieu-Daudé
2022-12-13 13:51 ` Peter Maydell
2022-12-16 19:10 ` Daniel Henrique Barboza
2022-12-16 21:39 ` Peter Maydell
2022-12-19 6:31 ` David Gibson
2022-12-19 10:39 ` Peter Maydell
2022-12-21 1:16 ` David Gibson
2022-12-21 12:33 ` Peter Maydell
2022-12-21 16:03 ` Cédric Le Goater
2022-12-21 22:15 ` Peter Maydell
2022-12-22 1:56 ` David Gibson
2022-12-13 12:52 ` [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu() Philippe Mathieu-Daudé
2022-12-13 13:53 ` Peter Maydell
2022-12-13 13:54 ` Edgar E. Iglesias
2022-12-13 14:18 ` Peter Maydell
2022-12-13 14:23 ` Edgar E. Iglesias
2022-12-13 15:22 ` Peter Maydell
2022-12-13 15:41 ` Edgar E. Iglesias
2024-04-22 12:46 ` Philippe Mathieu-Daudé
2022-12-13 16:56 ` [RFC PATCH-for-8.0 0/3] hw/ppc: Remove tswap() calls Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f4b5a6-0a8a-5a04-8ab6-f3f08b9d36aa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).