From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH v7 00/10] Introduce model for IBM's FSI
Date: Wed, 29 Nov 2023 08:56:34 -0600 [thread overview]
Message-ID: <a1fbfc7b-6f5a-44c4-9af4-65dac15763b6@linux.ibm.com> (raw)
In-Reply-To: <417e8a68-2f35-4315-b694-892f78c811b6@kaod.org>
Hello Cedric,
On 11/27/23 10:31, Cédric Le Goater wrote:
> Hello Ninad,
>
> On 10/26/23 18:47, Ninad Palsule wrote:
>> Hello,
>>
>> Please review the patch-set version 7.
>> I have incorporated review comments from Cedric, Philippe and Thomas.
>
>
> I reworked v7 with the suggestions I made in patches 1-6. Please check :
>
> https://github.com/legoater/qemu/commits/aspeed-8.2
>
> I will have more questions on the mappings because some parts are really
> unclear.
>
I forgot to mention in my last mail. If I build against your aspeed-8.2
branch then rainier machine is failing to boot.
The same images are working with qemu master branch.
fsi/qemu-system-arm -M rainier-bmc -nographic -kernel
./fitImage-linux.bin -dtb ./aspeed-bmc-ibm-rainier.dtb -initrd
./obmc-phosphor-initramfs.rootfs.cpio.xz -drive
file=./obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2 -append
'rootwait console=ttyS4,115200n8 root=PARTLABEL=rofs-a' -net nic -net
user,hostfwd=:127.0.0.1:3222-:22,hostfwd=:127.0.0.1:2234-:1234 -trace 'fsi*'
|
|
Starting systemd-udevd version 254^
[ 50.630407] /dev/disk/by-partlabel/rofs-a: Can't open blockdev
mount: mounting /dev/disk/by-partlabel/rofs-a on /mnt/rofs failed: No
such file or directory
/bin/sh: can't access tty; job control turned off
>
> Thanks,
>
> C.
>
>
>>
>> Ninad Palsule (10):
>> hw/fsi: Introduce IBM's Local bus
>> hw/fsi: Introduce IBM's scratchpad
>> hw/fsi: Introduce IBM's cfam,fsi-slave
>> hw/fsi: Introduce IBM's FSI
>> hw/fsi: IBM's On-chip Peripheral Bus
>> hw/fsi: Aspeed APB2OPB interface
>> hw/arm: Hook up FSI module in AST2600
>> hw/fsi: Added qtest
>> hw/fsi: Added FSI documentation
>> hw/fsi: Update MAINTAINER list
>>
>> MAINTAINERS | 8 +
>> docs/specs/fsi.rst | 138 +++++++++++++++
>> docs/specs/index.rst | 1 +
>> meson.build | 1 +
>> hw/fsi/trace.h | 1 +
>> include/hw/arm/aspeed_soc.h | 4 +
>> include/hw/fsi/aspeed-apb2opb.h | 33 ++++
>> include/hw/fsi/cfam.h | 34 ++++
>> include/hw/fsi/engine-scratchpad.h | 27 +++
>> include/hw/fsi/fsi-master.h | 30 ++++
>> include/hw/fsi/fsi-slave.h | 29 +++
>> include/hw/fsi/fsi.h | 36 ++++
>> include/hw/fsi/lbus.h | 43 +++++
>> include/hw/fsi/opb.h | 33 ++++
>> hw/arm/aspeed_ast2600.c | 19 ++
>> hw/fsi/aspeed-apb2opb.c | 272 +++++++++++++++++++++++++++++
>> hw/fsi/cfam.c | 173 ++++++++++++++++++
>> hw/fsi/engine-scratchpad.c | 93 ++++++++++
>> hw/fsi/fsi-master.c | 161 +++++++++++++++++
>> hw/fsi/fsi-slave.c | 78 +++++++++
>> hw/fsi/fsi.c | 25 +++
>> hw/fsi/lbus.c | 74 ++++++++
>> hw/fsi/opb.c | 74 ++++++++
>> tests/qtest/aspeed-fsi-test.c | 205 ++++++++++++++++++++++
>> hw/Kconfig | 1 +
>> hw/arm/Kconfig | 1 +
>> hw/fsi/Kconfig | 23 +++
>> hw/fsi/meson.build | 6 +
>> hw/fsi/trace-events | 13 ++
>> hw/meson.build | 1 +
>> tests/qtest/meson.build | 1 +
>> 31 files changed, 1638 insertions(+)
>> create mode 100644 docs/specs/fsi.rst
>> create mode 100644 hw/fsi/trace.h
>> create mode 100644 include/hw/fsi/aspeed-apb2opb.h
>> create mode 100644 include/hw/fsi/cfam.h
>> create mode 100644 include/hw/fsi/engine-scratchpad.h
>> create mode 100644 include/hw/fsi/fsi-master.h
>> create mode 100644 include/hw/fsi/fsi-slave.h
>> create mode 100644 include/hw/fsi/fsi.h
>> create mode 100644 include/hw/fsi/lbus.h
>> create mode 100644 include/hw/fsi/opb.h
>> create mode 100644 hw/fsi/aspeed-apb2opb.c
>> create mode 100644 hw/fsi/cfam.c
>> create mode 100644 hw/fsi/engine-scratchpad.c
>> create mode 100644 hw/fsi/fsi-master.c
>> create mode 100644 hw/fsi/fsi-slave.c
>> create mode 100644 hw/fsi/fsi.c
>> create mode 100644 hw/fsi/lbus.c
>> create mode 100644 hw/fsi/opb.c
>> create mode 100644 tests/qtest/aspeed-fsi-test.c
>> create mode 100644 hw/fsi/Kconfig
>> create mode 100644 hw/fsi/meson.build
>> create mode 100644 hw/fsi/trace-events
>>
>
next prev parent reply other threads:[~2023-11-29 14:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 16:47 [PATCH v7 00/10] Introduce model for IBM's FSI Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 01/10] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-11-27 16:04 ` Cédric Le Goater
2023-11-28 17:22 ` Ninad Palsule
2023-11-27 16:30 ` Cédric Le Goater
2023-11-28 22:19 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 02/10] hw/fsi: Introduce IBM's scratchpad Ninad Palsule
2023-11-27 16:09 ` Cédric Le Goater
2023-11-28 22:30 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave Ninad Palsule
2023-11-27 16:16 ` Cédric Le Goater
2023-11-28 22:35 ` Ninad Palsule
2023-11-27 16:31 ` Cédric Le Goater
2023-11-28 22:36 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 04/10] hw/fsi: Introduce IBM's FSI Ninad Palsule
2023-11-27 16:19 ` Cédric Le Goater
2023-11-28 22:43 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 05/10] hw/fsi: IBM's On-chip Peripheral Bus Ninad Palsule
2023-11-27 16:23 ` Cédric Le Goater
2023-11-28 22:46 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 06/10] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-11-27 16:25 ` Cédric Le Goater
2023-11-28 22:47 ` Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 07/10] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 08/10] hw/fsi: Added qtest Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 09/10] hw/fsi: Added FSI documentation Ninad Palsule
2023-10-26 16:47 ` [PATCH v7 10/10] hw/fsi: Update MAINTAINER list Ninad Palsule
2023-11-27 16:31 ` [PATCH v7 00/10] Introduce model for IBM's FSI Cédric Le Goater
2023-11-28 22:49 ` Ninad Palsule
2023-11-29 14:56 ` Ninad Palsule [this message]
2023-11-29 21:29 ` Cédric Le Goater
2023-11-29 21:39 ` Cédric Le Goater
2023-11-30 16:14 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1fbfc7b-6f5a-44c4-9af4-65dac15763b6@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).