From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Ben Warren <ben@skyportsystems.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] accel: cleanup error output
Date: Tue, 18 Jul 2017 08:19:58 +0200 [thread overview]
Message-ID: <a20b1ea8-97b9-b206-e1fd-b3f358250a1f@redhat.com> (raw)
In-Reply-To: <20170717144527.24534-1-lvivier@redhat.com>
On 17.07.2017 16:45, Laurent Vivier wrote:
> Only emit "XXX accelerator not found", if there are not
> further accelerators listed. eg
>
> accel=kvm:tcg
>
> doesn't print a "KVM accelerator not found" warning
> when it falls back to tcg, but a
>
> accel=kvm
>
> prints a warning, since no fallback is given.
>
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> v2: replace "fprintf(stderr, ...)" by error_report()
I gave it a try, and it seems to work fine, thanks!
Tested-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2017-07-18 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 14:45 [Qemu-devel] [PATCH v2] accel: cleanup error output Laurent Vivier
2017-07-17 15:19 ` Eric Blake
2017-07-18 6:19 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20b1ea8-97b9-b206-e1fd-b3f358250a1f@redhat.com \
--to=thuth@redhat.com \
--cc=ben@skyportsystems.com \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).