Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches

[Collin Walling <walling@linux.ibm.com>]

On 2/1/19 4:18 AM, David Hildenbrand wrote:
> On 01.02.19 09:35, Cornelia Huck wrote:
>> On Thu, 31 Jan 2019 15:43:16 -0500
>> Collin Walling <walling@linux.ibm.com> wrote:
>>
>>> On 1/30/19 10:57 AM, David Hildenbrand wrote:
>>>> These are all the patches that are not yet upstream (@Conny you might
>>>> already picked some, including them for the full picture) and after
>>>> a good discussion yesterday, including a patch t get rid of the release
>>>> timer. I ran a couple of sanity tests on this series.
>>>>
>>>> #1 and #2 fix hotplugging of PCI bridges.
>>>> #3 warns when "zpci=off"
>>>> #4 refactors unplugging
>>>> #5 get's rid of the release timer
>>>> #6 processes all unplug requests on reboot
>>>>
>>>> @Colin, can you review/ack? Especially Patch #4 is needed for qdev
>>>> patches already on the list. ("[PATCH RFCv2 0/9] qdev: Hotplug handler
>>>> chaining + virtio-pmem")
>>>
>>> I've given my r-b for 4, 5, and 6. IIRC, the other patches in this
>>> series looked fine from previous versions, but I'd like to look at them
>>> more carefully before ack'ing. Please allow me some time to devote to
>>> them in the near future. Trying my best to balance things :)
>>
>> Great, thanks for looking. If patches 4-6 can be applied without
>> patches 1-3 (I think they can?), I'll go ahead and queue them.
> 
> Yes, I think they can, patch 1-3 mainly deals with plugging, these ones
> with unplugging. Thanks Conny!
> 
>>
>> (I'll probably send a pull request next week, will be happy to include
>> the other patches as well.)
>>
> 
> 

I noted the conflict you ran into when applying. I'll try to get to
reviewing the other patches either by today or Monday. If for some
reason I don't get to it by then, please ping me.