From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:54149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpazf-0002Nl-RJ for qemu-devel@nongnu.org; Fri, 01 Feb 2019 10:44:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpazd-0000My-I3 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 10:44:39 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58022 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gpazb-0000Jy-KN for qemu-devel@nongnu.org; Fri, 01 Feb 2019 10:44:35 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x11FT8Qs007829 for ; Fri, 1 Feb 2019 10:44:24 -0500 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0b-001b2d01.pphosted.com with ESMTP id 2qcpp90asc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 01 Feb 2019 10:44:24 -0500 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Feb 2019 15:44:23 -0000 References: <20190130155733.32742-1-david@redhat.com> <4fec7d60-1d09-ba37-c66a-1d86088a1c0e@linux.ibm.com> <20190201093524.321787a2.cohuck@redhat.com> <2bcb9cac-d8af-bfd4-e080-9650492ab770@redhat.com> From: Collin Walling Date: Fri, 1 Feb 2019 10:44:20 -0500 MIME-Version: 1.0 In-Reply-To: <2bcb9cac-d8af-bfd4-e080-9650492ab770@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , Cornelia Huck Cc: Thomas Huth , Pierre Morel , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson On 2/1/19 4:18 AM, David Hildenbrand wrote: > On 01.02.19 09:35, Cornelia Huck wrote: >> On Thu, 31 Jan 2019 15:43:16 -0500 >> Collin Walling wrote: >> >>> On 1/30/19 10:57 AM, David Hildenbrand wrote: >>>> These are all the patches that are not yet upstream (@Conny you might >>>> already picked some, including them for the full picture) and after >>>> a good discussion yesterday, including a patch t get rid of the release >>>> timer. I ran a couple of sanity tests on this series. >>>> >>>> #1 and #2 fix hotplugging of PCI bridges. >>>> #3 warns when "zpci=off" >>>> #4 refactors unplugging >>>> #5 get's rid of the release timer >>>> #6 processes all unplug requests on reboot >>>> >>>> @Colin, can you review/ack? Especially Patch #4 is needed for qdev >>>> patches already on the list. ("[PATCH RFCv2 0/9] qdev: Hotplug handler >>>> chaining + virtio-pmem") >>> >>> I've given my r-b for 4, 5, and 6. IIRC, the other patches in this >>> series looked fine from previous versions, but I'd like to look at them >>> more carefully before ack'ing. Please allow me some time to devote to >>> them in the near future. Trying my best to balance things :) >> >> Great, thanks for looking. If patches 4-6 can be applied without >> patches 1-3 (I think they can?), I'll go ahead and queue them. > > Yes, I think they can, patch 1-3 mainly deals with plugging, these ones > with unplugging. Thanks Conny! > >> >> (I'll probably send a pull request next week, will be happy to include >> the other patches as well.) >> > > I noted the conflict you ran into when applying. I'll try to get to reviewing the other patches either by today or Monday. If for some reason I don't get to it by then, please ping me.